Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update for v0.0.5 #114

Merged
merged 1 commit into from
Jul 20, 2022
Merged

Update for v0.0.5 #114

merged 1 commit into from
Jul 20, 2022

Conversation

jas88
Copy link
Member

@jas88 jas88 commented Jul 20, 2022

We need a release to get SMI back in sync with transitive dependencies. There are quite a few code changes since 0.0.4; I've documented all the dependency ones in CHANGELOG.md but don't know enough to be sure about the C# changes.

@jas88 jas88 requested a review from tznind July 20, 2022 00:40
@jas88 jas88 self-assigned this Jul 20, 2022
Copy link
Contributor

@tznind tznind left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok actually looks like theres a ton of C# changes that... didn't go through PR?

https://github.com/SMI/IsIdentifiable/compare/v0.0.4..main

7,729 lines changed

Looks like this commit detonated the repo 1dae8d6

This is the PR where it all went down:
#46

@jas88
Copy link
Member Author

jas88 commented Jul 20, 2022

@tznind Aargh - well spotted, sorry about that, almost all whitespace changes from ReSharpering it while I was doing the fo-dicom 5 update.

@jas88 jas88 merged commit 955e7f4 into main Jul 20, 2022
@jas88 jas88 deleted the release/v0.0.5 branch July 20, 2022 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants