Check multiple image frames #67
Conversation
|
This pull request introduces 1 alert when merging 10b3ad9 into f81e65a - view on LGTM.com new alerts:
|
|
After wrestling with this for too many hours I've come to the conclusion that Magick.NET has a bug in its BMP-format writer. I've got it to work by using PGM format, because leptonica was built without support for anything else (GIF, JPEG, PNG, TIFF, ...). I tried building a new leptonica with more format support but it was rejected, probably because tesseract would also have to be rebuilt. But then we would have to be careful with the tesseract nuget package, although that needs an update anyway. For the moment I just want to get something I can now move into the safe haven for testing on real images. The main outstanding issue now is the lack of support for decompressing overlay data, and I'm not sure if that's down to a native codec issue or something else. |
|
@howff strange, have you opened a Github issue for it or got a test case? The whole leptonica/tesseract tangle is a pain in other ways. We might also get some benefit from switching to SharpImage if suitable (since fo-dicom uses that for non-Windows-specific image handling anyway) - ImageMagick is probably massive overkill for our needs, so might be bringing excess baggage we could trim off. |
… converting internally
| mi.Negate(); | ||
| memStreamOut.Position = 0; | ||
| mi.Write(memStreamOut); | ||
| mi.Write($"{fi.FullName}.frame{frameNum}.png", MagickFormat.Png); // XXX debugging |
There was a problem hiding this comment.
debugging == remove before merge?
Loop through all frames of the main image and process them in turn.
Might be better to try/catch inside the frame loop though.
For more info see: #58