Monsters Reorg #199
Closed
Monsters Reorg #199
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Вынес предметы из items.* , добавил отдельную папку для кода классов item_*
SNMetamorph
requested changes
Nov 16, 2023
SNMetamorph
approved these changes
Nov 18, 2023
|
Тупой вопрос. А зачем по хедеру заводить на каждую энтити? Они же
самодостаточны, более того в друг друга смотреть по хорошему им совершенно
необязательно.
…
Message ID: ***@***.***>
|
|
А ты смотри с точки зрения, что нам потенциально может понадобиться какой-то новый функционал. И можно просто у любой энтити подключить хидер и спокойно унаследоваться от класса без вообще каких-либо проблем, если к примеру нам принципиально новая энтити не нужна, а мы просто хотим чуть-чуть изменить существующую |
|
Тоже верно, поэтому и вопрос тупой :)
…
Message ID: ***@***.***>
|
|
Manually merged into #197 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.