Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor load_image #60

Closed
emirkmo opened this issue Mar 12, 2022 · 2 comments · Fixed by #58
Closed

Refactor load_image #60

emirkmo opened this issue Mar 12, 2022 · 2 comments · Fixed by #58

Comments

@emirkmo
Copy link
Member

emirkmo commented Mar 12, 2022

load_image now contains sites/instruments, as well as the FlowsImage dataclass. This should all be refactored out of load_image.
@emirkmo
Copy link
Member Author

emirkmo commented Mar 12, 2022

Currently, the instrument and FlowsImage classes do not obey Open/Close principle at a minimum. So that should also be fixed.

@emirkmo emirkmo linked a pull request May 16, 2022 that will close this issue
Refactor load_img #58
Merged
@emirkmo
Copy link
Member Author

emirkmo commented May 16, 2022

basic refactor is done and working on devel. Need to test vs. the larger archive.

@emirkmo emirkmo closed this as completed May 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Refactor load_img SNflows/flows
1 participant
@emirkmo