Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[platform/Ali] Add optical module I2C bus recovery. #68

Merged
merged 1 commit into from Apr 11, 2019
Merged

[platform/Ali] Add optical module I2C bus recovery. #68

merged 1 commit into from Apr 11, 2019

Conversation

pphuchar
Copy link
Collaborator

@pphuchar pphuchar commented Apr 8, 2019

- What I did
Add the feature to detect the Optical Module I2C bus recovery on Fishbone32, Fishbone48, and Phalanx. This prevent whole I2C bus lockup when a single optical module is hanging up.

- How I did it
Update the BSP driver to detect the bus stuck when doing I2C transfer.
If the bus stuck found, report error to kernel log. Then trying to recovery by resetting the I2C switch chip.

- How to verify it

  1. Simulate the optical module bus stuck by pull SDA of SFP port1 to logic low.
  2. Try to access the port using sfputil show eeprom -p Ethernet0
  3. Check the kernel log for error report.
  4. Try to access other port I2C sfputil show eeprom -p Ethernetx with success.
  5. The bus stuck must not block other port I2C access.

- Description for the changelog

*Add optical module I2C bus recovery on Fishbone32, Fishbone48, and Phalanx.

- A picture of a cute animal (not mandatory but encouraged)

@pphuchar pphuchar requested a review from tiantianlv April 8, 2019 06:07
@pphuchar pphuchar changed the title [platform/module] Add optical module I2C bus recovery. [platform/Ali] Add optical module I2C bus recovery. Apr 8, 2019
@tiantianlv tiantianlv merged commit ccf1243 into SONIC-DEV:201811_cel Apr 11, 2019
mudsut4ke pushed a commit that referenced this pull request Mar 16, 2021
- Adding instructions to build telemetry server/go client inside docker (#68)
- Add RBAC, gNOI, API Versioning and Bulk Set operations. (#61) …
- Support NonTLS option for testing purpose only. (#67) …
- Oc gnmi examples (#62) …
jerseyang pushed a commit that referenced this pull request Jun 4, 2021
- Adding instructions to build telemetry server/go client inside docker (#68)
- Add RBAC, gNOI, API Versioning and Bulk Set operations. (#61) …
- Support NonTLS option for testing purpose only. (#67) …
- Oc gnmi examples (#62) …
jerseyang pushed a commit that referenced this pull request Oct 12, 2021
e466ac226c48cf87f83aa5564efd7155ac97a0c1 (HEAD -> master, origin/master, origin/HEAD) Reject incorrect CIDR addresses while configuring routes (#91)
07cf59d866914ef7cb6901d51f289f0bee721e44 [CI] Set up Azure pipeline (#89)
47476acdfaf668ab0cd9ae2443205a3bdc2e9ef9 Upgrade Go version to 1.14 (#90)
ee887c785c10d8b4f70db90ca50cc398327c5d73 Added flag to make go/pkg/ folder writable (removable) (#87)
6cfc8fe110c46a1ee5a8430e02a440b5a7b4006d (origin/shilongliu/azp) Default Vrf static route support (#85)
d3e8b8e4aee278fa11d7d86acabdab3fffc70d5a Add BFD config to subinterface and neighbor (#68)
8d4fd4a56b637d3b7403c321aef36b8dff58cd62 Fix WS-2018-0594 potential non-random UUIDs security issue (#78)
fad87fa20f6b15e28c90e02a131c44d236d6a751 Update API description for default vrf and ecmp routes (#82)

Signed-off-by: Abhishek Dosi <abdosi@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants