Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The same person can be added multiple times as event participant to the same event via the mobile app #12794

Closed
adinaflorea9 opened this issue Nov 29, 2023 · 2 comments · Fixed by #12843 or #12893
Assignees
Labels
android-app Affects the Android app bug An error or misbehavior of an existing feature (ticket type) events major A functional requirement is incorrect or incomplete, ... (Severity for bugs/defects) qa-verified Issue has been tested and verified by QA

Comments

@adinaflorea9
Copy link

Bug Description

In the mobile app via the regular create event participant flow, via the mobile app 'line listing' of event participants and via linking events to existing cases and contacts, the same person can be added multiple times as event participant to the same event.

Reproduction Steps

I: Via the regular create event participant flow:

  1. Log into the mobile app with a Default Surveillance Officer;
  2. Open an existing event that you have access to;
  3. Open the 'Event Participants' tab and click on the pencil icon to enter edit mode;
  4. Then click on the + icon to add a new event participant;
  5. Fill in the mandatory information and save;
  6. Then navigate again on the same event to the 'Event participants' tab
  7. Click to add another event participant;
  8. Write in the form the exact same data as at step 5 and click to save;
  9. In the 'Pick or create person' select the existing person and click 'Select';
    Actual behavior: The same person is now listed twice as event participant to the same event. After sync, this is also visible in the web app.

II: Via the mobile app 'line listing' ('Use rapid event participant entry')

  1. Log into the mobile app with a Default Surveillance Officer;
  2. Open an existing event that you have access to;
  3. Open the 'Event Participants' tab and click on the pencil icon to enter edit mode;
  4. Then click on the + icon to add a new event participant;
  5. Click on the checkbox 'Use rapid event participant entry';
  6. Fill in the mandatory information and save;
  7. In the next form, add again the exact same information as for the previous event participant and save;
  8. In the 'Pick or create person' select the existing person and click 'Select';
  9. Navigate back to the event and observe the list of participants.
    Actual behavior: The same person is now listed as event participant to the same event. After sync, this is also visible in the web app.

III: Via linking an event to a case or contact

  1. Log into the web app with a Default Surveillance Officer;
  2. Open an existing event that you have access to;
  3. Add a new event participant to that event and save;
  4. Then navigate to the persons directory and look for the person created at step 3;
  5. Create a case for that person;
  6. Log in the mobile app with the same Default Surveillance Officer and sync everything;
  7. Open the event used at step 2 and navigate to the 'Event participants' tab;
  8. Click on the pencil icon to enable editing and then on the + to create a new event participant;
  9. In the form, enter the exact same data as at step 3 and save;
  10. In the pick or create person select the existing person and click 'Select';
    Actual behavior: The same person is now listed as event participant to the same event. After sync, this is also visible in the web app.

IV: Via linking an event to a case or contact

  1. Log into the web app with a Default Surveillance Officer;
  2. Open an existing event that you have access to;
  3. Add a new event participant to that event and save;
  4. Then navigate to the persons directory and look for the person created at step 3;
  5. Create a case for that person;
  6. Log in the mobile app with the same Default Surveillance Officer and sync everything;
  7. Open the case created at step 7 and navigate to the 'Case events' tab;
  8. Click to add an event and select the event from step 2;
  9. Save everything and then navigate to the 'Event participants' tab of the event.
    Actual behavior: The same person is now listed as event participant to the same event. After sync, this is also visible in the web app.

Expected Behavior

At each of the scenarios, in the moment when the user tries to save an event participant that is for the same person, in the same event, the user should see a pop-up that informs them that the person is already an event participant in the same event, similar to how we have this in the web app.

Active and archived event participants in the same event should be taken into account.

Affected Area(s)

Android app

SORMAS Version

1.92.0, 1.91.0

Android version/Browser

Android Studio

User Role(s)

Default Surveillance Officer

Server URL

local machine

Additional Information

No response

@adinaflorea9 adinaflorea9 added bug An error or misbehavior of an existing feature (ticket type) android-app Affects the Android app events major A functional requirement is incorrect or incomplete, ... (Severity for bugs/defects) labels Nov 29, 2023
@carina29 carina29 self-assigned this Dec 14, 2023
carina29 added a commit that referenced this issue Jan 4, 2024
carina29 added a commit that referenced this issue Jan 8, 2024
MateStrysewske added a commit that referenced this issue Jan 8, 2024
* #12806 - Hide immunization jurisdiction fields

* #12794 - Fix insert command

---------

Co-authored-by: Carina Paul <carina.paul@she.net>
carina29 added a commit that referenced this issue Jan 8, 2024
carina29 added a commit that referenced this issue Jan 8, 2024
carina29 added a commit that referenced this issue Jan 8, 2024
carina29 added a commit that referenced this issue Jan 10, 2024
carina29 added a commit that referenced this issue Jan 11, 2024
MateStrysewske pushed a commit that referenced this issue Jan 12, 2024
…ted (#12843)

* #12794 - The same event participant should not be allowed to be selected

* #12794- Fix linking an event to a case bug

* #12794 - fix

* #12794 - changes after review

* #12794 - Display proper message if only the event participant was linked not the event
@adinaflorea9 adinaflorea9 self-assigned this Jan 12, 2024
@adinaflorea9
Copy link
Author

I am reopening the ticket as the behavior described at scenario IV is still reproducible.

IV: Via linking an event to a case or contact

  1. Log into the web app with a Default Surveillance Officer;
  2. Open an existing event that you have access to;
  3. Add a new event participant to that event and save;
  4. Then navigate to the persons directory and look for the person created at step 3;
  5. Create a case for that person;
  6. Log in the mobile app with the same Default Surveillance Officer and sync everything;
  7. Open the case created at step 7 and navigate to the 'Case events' tab;
  8. Click to add an event and select the event from step 2;
  9. Save everything and then navigate to the 'Event participants' tab of the event.

Actual behavior: The same person is now listed as event participant to the same event. After sync, this is also visible in the web app once without a resulting case and once with the resulting case.

Expected behavior: The person should be listed as an event participant to that event only once, and the case should be linked to that event participant after step 8.

image

@adinaflorea9 adinaflorea9 reopened this Jan 14, 2024
carina29 added a commit that referenced this issue Jan 16, 2024
MateStrysewske added a commit that referenced this issue Jan 17, 2024
…_case_with_existent_event_participant

#12794 - Link event to case with existent event participant
@adinaflorea9
Copy link
Author

Verified ticket on the local machine using the latest version of SORMAS from the development branch - 1.94.0-SNAPSHOT(75fa116).

@adinaflorea9 adinaflorea9 added the qa-verified Issue has been tested and verified by QA label Jan 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
android-app Affects the Android app bug An error or misbehavior of an existing feature (ticket type) events major A functional requirement is incorrect or incomplete, ... (Severity for bugs/defects) qa-verified Issue has been tested and verified by QA
Projects
None yet
2 participants