Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Align contact information icon for reporting user to the left [1] #12820

Closed
2 tasks
bernardsilenou opened this issue Dec 7, 2023 · 1 comment · Fixed by #12888
Closed
2 tasks

Align contact information icon for reporting user to the left [1] #12820

bernardsilenou opened this issue Dec 7, 2023 · 1 comment · Fixed by #12888
Assignees
@carina29 @adinaflorea9
Labels
change A change of an existing feature (ticket type) general Not directly concerned with any particular functional section of the application qa-verified Issue has been tested and verified by QA ready Issue fulfills the definition of ready and can be implemented vaadin-app Affects the Vaadin application
Milestone
Iteration 2023-15...

Comments

@bernardsilenou
Copy link

Problem Description

Issue #6667 added contact information on edit forms for many entities. The icon is far from the caption "reporting user" and closer to the boxes (e.g task) on the right. The information in the pop-up does not contain text linking it to the reporting user information

Proposed Change

Bring the icon to the left, as close to the caption as possible
image

Added Value/Benefit

Improve design and understanding of captions

Acceptance Criteria

  • The eys icon is as close to the caption "responsible user" as possible
  • If the resolution of the browser size is reduced, both the caption and icon stay together
  • [ ]

Implementation Details

No response

Mockups

No response

Additional Information

No response
@bernardsilenou bernardsilenou added the change A change of an existing feature (ticket type) label Dec 7, 2023
@MateStrysewske MateStrysewske added vaadin-app Affects the Vaadin application general Not directly concerned with any particular functional section of the application ready Issue fulfills the definition of ready and can be implemented labels Dec 15, 2023
@AndyBakcsy-she AndyBakcsy-she changed the title Align contact information icon for reporting user to the left Align contact information icon for reporting user to the left [1] Dec 20, 2023
@carina29 carina29 self-assigned this Jan 5, 2024
carina29 added a commit that referenced this issue Jan 15, 2024
@carina29
#12820 - Align contact information icon
75c8153
@carina29 carina29 mentioned this issue Jan 15, 2024
Merged
carina29 added a commit that referenced this issue Jan 16, 2024
@carina29
#12820 - Add reportingUser to the Contact information popup
90f2fe5
carina29 added a commit that referenced this issue Jan 16, 2024
@carina29
Merge branch 'development' into #12820-Align_contact_information_icon
950f5d9
MateStrysewske pushed a commit that referenced this issue Jan 17, 2024
@carina29
#12820 - Align contact information icon (#12888)
c51fb3d 
* #12820 - Align contact information icon

* #12820 - Add reportingUser to the Contact information popup
@adinaflorea9 adinaflorea9 self-assigned this Jan 17, 2024
@adinaflorea9
Copy link

Verified ticket on the local machine using the latest version of SORMAS from the development branch - 1.94.0-SNAPSHOT(75fa116).

@adinaflorea9 adinaflorea9 added the qa-verified Issue has been tested and verified by QA label Jan 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@carina29 carina29

@adinaflorea9 adinaflorea9

Labels
change A change of an existing feature (ticket type) general Not directly concerned with any particular functional section of the application qa-verified Issue has been tested and verified by QA ready Issue fulfills the definition of ready and can be implemented vaadin-app Affects the Vaadin application
Projects
None yet
Milestone
Iteration 2023-15 - 1.94.0
Development

Successfully merging a pull request may close this issue.

#12820 - Align contact information icon SORMAS-Foundation/SORMAS-Project
4 participants
@bernardsilenou @MateStrysewske @carina29 @adinaflorea9