Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add validation to the national health ID field [0.5] #12841

Closed
3 tasks done
MateStrysewske opened this issue Dec 21, 2023 · 2 comments · Fixed by #12897
Closed
3 tasks done

Add validation to the national health ID field [0.5] #12841

MateStrysewske opened this issue Dec 21, 2023 · 2 comments · Fixed by #12897
Assignees
@leventegal-she @adinaflorea9
Labels
feature A new feature to be developed (ticket type) lu Adaptations requested by or implemented for Luxembourg persons qa-verified Issue has been tested and verified by QA ready Issue fulfills the definition of ready and can be implemented vaadin-app Affects the Vaadin application
Milestone
Iteration 2023-15...

Comments

@MateStrysewske
Copy link
Contributor

MateStrysewske commented Dec 21, 2023 •
edited by leventegal-she
Loading

Feature Description

Sending external emails to persons utilises their national health ID to add password protection. However, this requires the national health ID to be correct; otherwise, a password is generated and sent to the user via SMS. In order to make it less probable that an invalid national health ID is in use, the same validation that is already in use should be applied to the field in the person form as well.

Added Value/Benefit

More reliably correct national health ID.

Acceptance Criteria

  • The same logic that is used in order to identify a correct national health ID when sending external emails is applied to the national health ID field in the person create and edit forms
  • If an invalid national health ID is entered, display a warning: "This does not seem to be a correct national health ID" - saving the form should still be possible
  • This new logic is only applied to Luxembourg servers

Implementation Details

No response

Mockups

No response

Additional Information

No response
@MateStrysewske MateStrysewske added vaadin-app Affects the Vaadin application feature A new feature to be developed (ticket type) persons ready Issue fulfills the definition of ready and can be implemented lu Adaptations requested by or implemented for Luxembourg labels Dec 21, 2023
@markusmann-vg markusmann-vg changed the title Add validation to the national health ID field Add validation to the national health ID field [0.5] Jan 8, 2024
@leventegal-she leventegal-she self-assigned this Jan 17, 2024
leventegal-she pushed a commit that referenced this issue Jan 18, 2024
#12841 Add validation to the national health ID field
5bf0278
@leventegal-she leventegal-she mentioned this issue Jan 18, 2024
Merged
leventegal-she pushed a commit that referenced this issue Jan 25, 2024
#12841 Add validation to the national health ID field
11e56c8
leventegal-she added a commit that referenced this issue Jan 25, 2024
@leventegal-she
Merge pull request #12897 from SORMAS-Foundation/feature-12841-Add-va…
a4cb6d6 
…lidation-to-the-national-health-ID-field

#12841 Add validation to the national health ID field
@MateStrysewske
Copy link
Contributor Author

Error message below the field is always shown on non-Luxembourg systems

leventegal-she pushed a commit that referenced this issue Jan 30, 2024
#12841 Add validation to the national health ID field [0.5] - fixed m…
2e233ba 
…inor issues
@adinaflorea9 adinaflorea9 self-assigned this Jan 31, 2024
@adinaflorea9
Copy link

Verified ticket on the local machine using the latest version of SORMAS from the development branch - .194.0-SNAPSHOT(6374a28).

@adinaflorea9 adinaflorea9 added the qa-verified Issue has been tested and verified by QA label Jan 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@leventegal-she leventegal-she

@adinaflorea9 adinaflorea9

Labels
feature A new feature to be developed (ticket type) lu Adaptations requested by or implemented for Luxembourg persons qa-verified Issue has been tested and verified by QA ready Issue fulfills the definition of ready and can be implemented vaadin-app Affects the Vaadin application
Projects
None yet
Milestone
Iteration 2023-15 - 1.94.0
Development

Successfully merging a pull request may close this issue.

#12841 Add validation to the national health ID field SORMAS-Foundation/SORMAS-Project
3 participants
@MateStrysewske @leventegal-she @adinaflorea9