Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

'Unsaved changes' pop-up is not triggered and 'Discard' button does not take into account changes in the responsible user fields #12850

Closed
adinaflorea9 opened this issue Dec 27, 2023 · 2 comments · Fixed by #12921 or #12926
Assignees
Labels
bug An error or misbehavior of an existing feature (ticket type) cases contacts environment events major A functional requirement is incorrect or incomplete, ... (Severity for bugs/defects) qa-verified Issue has been tested and verified by QA vaadin-app Affects the Vaadin application

Comments

@adinaflorea9
Copy link

Bug Description

If changes are made in the following fields:

  • responsible surveillance officer;
  • responsible contact officer;
  • responsible user (event page);
  • responsible user (environment page);
    and then the user clicks 'Discard' the changes made in the filed are are discarded on the spot. If the user makes the changes and then navigates to another tab of the app, the 'Unsaved changes' pop-up does not get triggered.

Reproduction Steps

  1. Logged in with and Admin+NatUser make changes on any of the fields mentioned in the bug description;
  2. While on the page where you made changes, click 'Discard' or navigate to any other tab of the app.
    Actual behavior: discard is not done/ 'Unsaved changes' pop-up is not triggered.

Expected Behavior

Clicking on 'Discard' should discard any changes that were not previously saved on the respective page.

When navigating from a tab/page to another and there are unsaved changes on the initial page, trigger the 'Unsaved changes' pop-up.

Affected Area(s)

Web app

SORMAS Version

1.94.0, 1.93.0

Android version/Browser

Chrome

User Role(s)

Admina+NatUser

Server URL

local machine

Additional Information

No response

@adinaflorea9 adinaflorea9 added bug An error or misbehavior of an existing feature (ticket type) contacts cases events environment major A functional requirement is incorrect or incomplete, ... (Severity for bugs/defects) vaadin-app Affects the Vaadin application labels Dec 27, 2023
@sergiupacurariu sergiupacurariu self-assigned this Jan 26, 2024
sergiupacurariu added a commit that referenced this issue Jan 29, 2024
…on does not take into account changes in the responsible user fields
sergiupacurariu added a commit that referenced this issue Jan 29, 2024
…on does not take into account changes in the responsible user fields
sergiupacurariu added a commit that referenced this issue Jan 29, 2024
…on does not take into account changes in the responsible user fields
leventegal-she added a commit that referenced this issue Jan 29, 2024
…_changes_popup_not_triggered_for_user_fields

#12850 - 'Unsaved changes' pop-up is not triggered and 'Discard' butt…
@adinaflorea9 adinaflorea9 self-assigned this Jan 29, 2024
@adinaflorea9
Copy link
Author

I am reopening the ticket due to the following:
image

When the user makes any change in the fields mentioned in the ticket's description, and then clicks 'Discard' the value in the field is not immediately updated to the previous value (similar to how we do it in other fields populated by values chosen from dropdowns).

@adinaflorea9 adinaflorea9 reopened this Jan 29, 2024
sergiupacurariu added a commit that referenced this issue Jan 31, 2024
…on does not take into account changes in the responsible user fields
leventegal-she added a commit that referenced this issue Jan 31, 2024
…card_issue_on_user_fields

#12850 - 'Unsaved changes' pop-up is not triggered and 'Discard' butt…
@adinaflorea9
Copy link
Author

Verified ticket on the local machine using the latest version of SORMAS from the development branch - 1.94.0-SNAPSHOT(6374a28).

@adinaflorea9 adinaflorea9 added the qa-verified Issue has been tested and verified by QA label Jan 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug An error or misbehavior of an existing feature (ticket type) cases contacts environment events major A functional requirement is incorrect or incomplete, ... (Severity for bugs/defects) qa-verified Issue has been tested and verified by QA vaadin-app Affects the Vaadin application
Projects
None yet
2 participants