Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hide the jurisdiction related fields from the 'Edit cases' form in bulk edit mode [1] #12902

Closed
3 tasks done
adinaflorea9 opened this issue Jan 19, 2024 · 2 comments · Fixed by #12910
Closed
3 tasks done

Hide the jurisdiction related fields from the 'Edit cases' form in bulk edit mode [1] #12902

adinaflorea9 opened this issue Jan 19, 2024 · 2 comments · Fixed by #12910
Assignees
@carina29
Labels
backend Affects the web backend cases change A change of an existing feature (ticket type) lu Adaptations requested by or implemented for Luxembourg qa-verified Issue has been tested and verified by QA ready Issue fulfills the definition of ready and can be implemented vaadin-app Affects the Vaadin application
Milestone
Iteration 2023-15...

Comments

@adinaflorea9
Copy link

adinaflorea9 commented Jan 19, 2024 •
edited by carina29
Loading

Problem Description

When the featuretype 'HIDE_JURISDICTION_FIELDS' in enabled we do not show in edit and creation forms the fields related to the jurisdiction - responsible region, district, community. But in bulk edit mode, in the cases directory, we still show them.

image

After the edit is done (select a different region, district than those that are set as default) - if the user goes to the regular edit pages of cases they can now see in the 'Place of stay section' the fields for region, district and community that were previously hidden.

Proposed Change

Hide the responsible region, district and community fields from the 'Edit cases' form in bulk edit mode.

Added Value/Benefit

Consistency.

Acceptance Criteria

  • hide the fields region, district and community from the 'Edit cases' form in bulk edit mode when the hide jurisdiction fields feature is enabled;
  • consider instead the default values set for region, district and community;
  • the user should still be able to change the place of stay - the option for home still present, the option for facility still present - but only facilities from the default jurisdiction being possible to be selected (just as in the regular edit forms of cases);

Implementation Details

No response

Mockups

No response

Additional Information

No response
@adinaflorea9 adinaflorea9 added cases backend Affects the web backend vaadin-app Affects the Vaadin application change A change of an existing feature (ticket type) ready Issue fulfills the definition of ready and can be implemented labels Jan 19, 2024
@markusmann-vg markusmann-vg added the lu Adaptations requested by or implemented for Luxembourg label Jan 19, 2024
carina29 added a commit that referenced this issue Jan 25, 2024
@carina29
#12902 - Hide jurisdiction related fields from bulk edit mode when hi…
9b3f1e8 
…de jurisdiction is true
carina29 added a commit that referenced this issue Jan 25, 2024
@carina29
#12902 - Hide region and district from Bulk edit mode for cases when …
1bff7b7 
…hide jurisdiction is true
@carina29 carina29 mentioned this issue Jan 25, 2024
Merged
carina29 added a commit that referenced this issue Jan 25, 2024
@carina29
Merge branch 'development' into #12902-Hide_jurisdiction_related_fiel…
90a1bd2 
…ds_from_cases_bulk_edit_Form
carina29 added a commit that referenced this issue Jan 25, 2024
@carina29
#12902 - Hide region, district , community and responsible region, di…
f9ee2f9 
…strict, community when HIDE_JURISDICTION is true
carina29 added a commit that referenced this issue Jan 25, 2024
@carina29
#12902 - delete todo
fa9cec2
carina29 added a commit that referenced this issue Jan 25, 2024
@carina29
Merge branch 'development' into #12902-Hide_jurisdiction_related_fiel…
b088437 
…ds_from_cases_bulk_edit_Form
@carina29 carina29 changed the title Hide the jurisdiction related fields from the 'Edit cases' form in bulk edit mode Hide the jurisdiction related fields from the 'Edit cases' form in bulk edit mode [1] Jan 25, 2024
carina29 added a commit that referenced this issue Jan 25, 2024
@carina29
#12902 - Delete the setDefault values from edit form
64680f8
carina29 added a commit that referenced this issue Jan 25, 2024
@carina29
#12902 - Renaming
775ad24
carina29 added a commit that referenced this issue Jan 25, 2024
@carina29
#12902 - Delete empty lines
58ed523
@carina29
Copy link
Contributor

I've found some bugs/findings meanwhile I've worked on this ticket and also discussed with @MateStrysewske about the findings.
I've created these tickets: #12917
#12918

MateStrysewske pushed a commit that referenced this issue Jan 26, 2024
@carina29
#12902 hide jurisdiction related fields from cases bulk edit form (#1…
c6972f4 
…2910)

* #12902 - Hide jurisdiction related fields from bulk edit mode when hide jurisdiction is true

* #12902 - Hide region and district from Bulk edit mode for cases when hide jurisdiction is true

* #12902 - Hide region, district , community and responsible region, district, community when HIDE_JURISDICTION is true

* #12902 - delete todo

* #12902 - Delete the setDefault values from edit form

* #12902 - Renaming

* #12902 - Delete empty lines
@adinaflorea9
Copy link
Author

Verified ticket on the local machine using the latest version of SORMAS from the development branch - 1.94.0-SNAPSHOT(dfc3af7).

@adinaflorea9 adinaflorea9 added the qa-verified Issue has been tested and verified by QA label Jan 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@carina29 carina29

Labels
backend Affects the web backend cases change A change of an existing feature (ticket type) lu Adaptations requested by or implemented for Luxembourg qa-verified Issue has been tested and verified by QA ready Issue fulfills the definition of ready and can be implemented vaadin-app Affects the Vaadin application
Projects
None yet
Milestone
Iteration 2023-15 - 1.94.0
Development

Successfully merging a pull request may close this issue.

#12902 hide jurisdiction related fields from cases bulk edit form SORMAS-Foundation/SORMAS-Project
4 participants
@carina29 @markusmann-vg @sergiupacurariu @adinaflorea9