#13157 - Disable Contact Management for RSV Cases #13178
Conversation
|
SonarCloud analysis: https://sonarcloud.io/dashboard?id=SORMAS-Project&pullRequest=13178 |
| @@ -233,6 +237,12 @@ protected ComboBox addDiseaseField(String fieldId, boolean showNonPrimaryDisease | |||
| newItem.getItemProperty(SormasFieldGroupFieldFactory.CAPTION_PROPERTY_ID).setValue(value.toString()); | |||
| } | |||
| }); | |||
|
|
|||
| // | |||
There was a problem hiding this comment.
please delete the empty comment
| @@ -233,6 +237,12 @@ protected ComboBox addDiseaseField(String fieldId, boolean showNonPrimaryDisease | |||
| newItem.getItemProperty(SormasFieldGroupFieldFactory.CAPTION_PROPERTY_ID).setValue(value.toString()); | |||
| } | |||
| }); | |||
|
|
|||
| // | |||
| if (hideFollowUpDisabledDiseases) { | |||
There was a problem hiding this comment.
this should be done before statement
There was a problem hiding this comment.
moved above the above statement
| @@ -503,6 +513,16 @@ protected void addNonPrimaryDiseasesTo(ComboBox diseaseField) { | |||
| } | |||
| } | |||
|
|
|||
| protected void removeFollowUpDisabledDiseases(ComboBox diseaseField) { | |||
There was a problem hiding this comment.
please merge this with the above function to avoid requesting and iterating over disease configurations
There was a problem hiding this comment.
this doesn't allow changing the followupEnabled from the DB because you always take the default value of the enum, you should use disease configuration instances to check wether followup is enabled or not.
So the filtering should be done on the backend
There was a problem hiding this comment.
update the method to retrieve the followUpEnabled diseases
|
SonarCloud analysis: https://sonarcloud.io/dashboard?id=SORMAS-Project&pullRequest=13178 |
leventegal-she
deleted the
feature-13157_Disable_contact_management_for_RSV_cases
branch
Fixes #13157