Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deb output #39

Merged
merged 12 commits into from
Dec 8, 2021
Merged

Deb output #39

merged 12 commits into from
Dec 8, 2021

Conversation

vinferrer
Copy link
Member

@vinferrer vinferrer commented Nov 29, 2021

Closes #27 .

Changes proposed in this pull request:

  • connPFM accepts a parameter for the prefix of debiasing files instead of assuming the name from the basename

@codecov
Copy link

codecov bot commented Nov 29, 2021

Codecov Report

Merging #39 (fc8c63f) into main (acda4c6) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #39      +/-   ##
==========================================
+ Coverage   86.13%   86.15%   +0.01%     
==========================================
  Files          15       15              
  Lines         815      816       +1     
==========================================
+ Hits          702      703       +1     
  Misses        113      113              
Impacted Files Coverage Δ
connPFM/connPFM.py 85.10% <ø> (ø)
connPFM/cli/connPFM.py 100.00% <100.00%> (ø)
connPFM/debiasing/debiasing.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update acda4c6...fc8c63f. Read the comment docs.

@vinferrer vinferrer marked this pull request as ready for review December 3, 2021 08:41
@vinferrer vinferrer requested a review from eurunuela December 3, 2021 08:41
@vinferrer vinferrer added enhancement New feature or request effort: low labels Dec 3, 2021
Copy link
Contributor

@eurunuela eurunuela left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @vinferrer , just one change I'd like to see before approving.

connPFM/debiasing/debiasing.py Outdated Show resolved Hide resolved
connPFM/tests/test_integration.py Outdated Show resolved Hide resolved
@vinferrer vinferrer requested a review from eurunuela December 8, 2021 09:33
Copy link
Contributor

@eurunuela eurunuela left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @vinferrer !

@vinferrer vinferrer merged commit 7ca2ade into SPiN-Lab:main Dec 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
effort: low enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Debiasing function should have a prefix option
2 participants