Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Output rss and peak timepoints as txt #47

Merged
merged 10 commits into from
Dec 10, 2021
Merged

Conversation

vinferrer
Copy link
Member

@vinferrer vinferrer commented Dec 10, 2021

Closes # .

Changes proposed in this pull request:

  • New argument on the cli
  • Now if this argument is entered then rss and peaks are outputed as txt

@vinferrer vinferrer requested a review from eurunuela December 10, 2021 11:48
@codecov
Copy link

codecov bot commented Dec 10, 2021

Codecov Report

Merging #47 (c5b3d61) into main (9d12893) will increase coverage by 0.41%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #47      +/-   ##
==========================================
+ Coverage   88.84%   89.26%   +0.41%     
==========================================
  Files          15       15              
  Lines         825      829       +4     
==========================================
+ Hits          733      740       +7     
+ Misses         92       89       -3     
Impacted Files Coverage Δ
connPFM/connPFM.py 85.10% <ø> (ø)
connPFM/cli/connPFM.py 100.00% <100.00%> (ø)
connPFM/connectivity/ev.py 98.79% <100.00%> (+3.79%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9d12893...c5b3d61. Read the comment docs.

@vinferrer vinferrer marked this pull request as ready for review December 10, 2021 14:22
@vinferrer vinferrer requested a review from eurunuela December 10, 2021 14:22
@vinferrer vinferrer added the enhancement New feature or request label Dec 10, 2021
Copy link
Contributor

@eurunuela eurunuela left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks @vinferrer !

@vinferrer vinferrer merged commit aa06310 into SPiN-Lab:main Dec 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants