Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change the download of the container to singularity library #56

Merged
merged 7 commits into from
Jan 26, 2022

Conversation

vinferrer
Copy link
Member

@vinferrer vinferrer commented Jan 26, 2022

Closes # .

Changes proposed in this pull request:

  • Adds singularity recipe for the slim container
  • singularity now downloads the container from singularity repository
  • errors from jobs now are separated in a file by job

@vinferrer vinferrer requested a review from eurunuela January 26, 2022 10:48
@vinferrer vinferrer marked this pull request as ready for review January 26, 2022 10:48
@codecov
Copy link

codecov bot commented Jan 26, 2022

Codecov Report

Merging #56 (0b4d6c2) into main (ffdd4b7) will decrease coverage by 0.10%.
The diff coverage is 0.00%.

❗ Current head 0b4d6c2 differs from pull request most recent head 228ea20. Consider uploading reports for the commit 228ea20 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##             main      #56      +/-   ##
==========================================
- Coverage   89.23%   89.12%   -0.11%     
==========================================
  Files          15       15              
  Lines         836      837       +1     
==========================================
  Hits          746      746              
- Misses         90       91       +1     
Impacted Files Coverage Δ
connPFM/deconvolution/roiPFM.py 96.00% <ø> (ø)
connPFM/deconvolution/stability_lars_caller.py 43.85% <0.00%> (-0.79%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ffdd4b7...228ea20. Read the comment docs.

Copy link
Contributor

@eurunuela eurunuela left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have a minor comment but won't hold the PR from being merged because of that.

connPFM/deconvolution/stability_lars_caller.py Outdated Show resolved Hide resolved
Copy link
Contributor

@eurunuela eurunuela left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@vinferrer vinferrer merged commit 21268b0 into SPiN-Lab:main Jan 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants