Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Folder structure and add files from previous repositories #6

Merged
merged 6 commits into from
Oct 6, 2021
Merged

Folder structure and add files from previous repositories #6

merged 6 commits into from
Oct 6, 2021

Conversation

vinferrer
Copy link
Member

Closes #1 .

Changes proposed in this pull request:

@vinferrer vinferrer requested a review from eurunuela October 6, 2021 10:05
@vinferrer vinferrer self-assigned this Oct 6, 2021
eurunuela
eurunuela requested changes Oct 6, 2021
View reviewed changes
Copy link
Contributor

@eurunuela eurunuela left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe you're missing a couple of files.

connPFM/deconvolution/roi_pfm.py Show resolved Hide resolved
@vinferrer vinferrer requested a review from eurunuela October 6, 2021 10:20
eurunuela
eurunuela requested changes Oct 6, 2021
View reviewed changes
connPFM/info.py Outdated Show resolved Hide resolved
eurunuela
eurunuela approved these changes Oct 6, 2021
View reviewed changes
Copy link
Contributor

@eurunuela eurunuela left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you @vinferrer !

@vinferrer vinferrer merged commit 9be08f0 into SPiN-Lab:main Oct 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eurunuela eurunuela eurunuela approved these changes

Assignees

@vinferrer vinferrer

Labels
hacktoberfest-accepted refactoring
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Folder_structure
2 participants
@vinferrer @eurunuela