This repository has been archived by the owner on Dec 9, 2017. It is now read-only.
XMLHttpRequest is not a function under JavaScriptCore / Safari #27
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, record-replay of jQuery 2.0.2 works fine on Chrome, but not in PhantomJS. The issue in PhantomJS is that for Safari's Webkit (JavaScriptCore),
typeof XMLHttpRequest
(and various other native functions) isobject
rather thanfunction
. (This behavior remains even for the most recent version of Safari.) This leads to replay errors for scripts like:During replay, we get the error:
The code change attached to this pull request "fixes" the problem, by special-casing the function test for XMLHttpRequest. But, it's a total hack. Unfortunately, I can't think of a more general way to detect and address this issue.
Is there a better way to fix this problem?