-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mario #79
base: humble
Are you sure you want to change the base?
Mario #79
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Most of the things look good to me, have to get tested
@@ -1,26 +1,3 @@ | |||
/* |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't remove license
display_logo(MARIO_LOGO); | ||
vTaskDelay(100); | ||
#endif | ||
#ifdef CONFIG_ENABLE_OLED |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remove the indentations
@@ -85,10 +50,6 @@ static void mcpwm_servo_control(void *arg) | |||
vTaskDelay(100); | |||
set_angle_servo(&servo_d, 0); | |||
vTaskDelay(100); | |||
#ifdef CONFIG_ENABLE_OLED | |||
// Diplaying Servo A, Servo B, Servo C, Servo D values on OLED | |||
display_servo_values(read_servo(&servo_a), read_servo(&servo_b), read_servo(&servo_c), read_servo(&servo_d)); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why was this function removed?
firmware/2_servo_sweep/main/main.c
Outdated
@@ -1,26 +1,3 @@ | |||
/* |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't remove license
Modify the structure in all firmware codes according to the struct defined in the servo.h code