Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Oled example #55

Merged
merged 6 commits into from
Feb 25, 2022
Merged

Conversation

gautam-dev-maker
Copy link
Collaborator

  • Add Oled Example in the SRA-BOARD-COMPONENT
  • Update github actions for oled-example

gautam-dev-maker and others added 3 commits February 23, 2022 15:57
* [CI] Debug error: "Not a git repository"

Signed-off-by: Shreyas Atre <shreyasatre16@gmail.com>

* [CI] Separately update submodules

Signed-off-by: Shreyas Atre <shreyasatre16@gmail.com>

* [CI] Remove github actions

Signed-off-by: Shreyas Atre <shreyasatre16@gmail.com>

* [CI] Change to checkout version 1

Signed-off-by: Shreyas Atre <shreyasatre16@gmail.com>
test-apps: [bar_graph, lsa, motor_driver_normal, motor_driver_parallel, mpu6050, servos, switches, oled]
steps:
- name: Setup Github Actions
uses: actions/checkout@v1
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why did you downgrade to v1 ?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://remarkablemark.org/blog/2021/02/21/github-actions-checkout-submodules/ Please follow the approach 1 here with checkout@v2

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please check log of the workflow with the suggestion 1 given.
Suggestion 2 workflow , log

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@SAtacker I had encountered this issue, just purge and install new git

sudo add-apt-repository ppa:git-core/ppa -y
sudo apt-get update
sudo apt-get install git -y

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, I had encountered this issue on the website as well. This works fine here: https://github.com/SRA-VJTI/sra-vjti.github.io/blob/main/.github/workflows/add-intern-exp.yaml

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://github.com/actions/virtual-environments/blob/c253e7f4d192e492988596167a1d461e99698c13/images/linux/Ubuntu2004-README.md#tools

According to this ubuntu-latest should have git 2.30.2. I guess the issue is with permission on gautam's fork. Please remove the changes and let's see if it fails in this repo.

@VedantParanjape
Copy link
Member

@gautam-dev-maker updates ?

@gautam-dev-maker
Copy link
Collaborator Author

I have reverted the commits regarding the github actions.

@VedantParanjape
Copy link
Member

@gautam-dev-maker you still need to change the yaml file to include oled folder of the examples

@VedantParanjape
Copy link
Member

@gautam-dev-maker you also need to enable submodule in git checkout #55 (comment)

CC: @SAtacker

@VedantParanjape VedantParanjape merged commit c71b816 into SRA-VJTI:main Feb 25, 2022
@gautam-dev-maker gautam-dev-maker deleted the oled_example branch February 26, 2022 10:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants