-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(pillarbox-debug-panel): debug panel component for playback metrics #30
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Coverage Report
File Coverage
|
|
jboix
force-pushed
the
feat/pillarbox-debug-panel
branch
from
August 13, 2024 11:27
b45c4ce
to
a2eb64b
Compare
jboix
force-pushed
the
feat/pillarbox-debug-panel
branch
from
August 13, 2024 11:33
a2eb64b
to
55fb827
Compare
jboix
force-pushed
the
feat/pillarbox-debug-panel
branch
2 times, most recently
from
August 20, 2024 08:15
98ce4f2
to
bbbc229
Compare
amtins
requested changes
Aug 20, 2024
amtins
reviewed
Aug 21, 2024
amtins
reviewed
Aug 21, 2024
amtins
reviewed
Aug 21, 2024
jboix
force-pushed
the
feat/pillarbox-debug-panel
branch
from
August 27, 2024 09:54
bbbc229
to
0fef226
Compare
amtins
reviewed
Aug 29, 2024
amtins
reviewed
Aug 29, 2024
amtins
reviewed
Aug 29, 2024
jboix
force-pushed
the
feat/pillarbox-debug-panel
branch
2 times, most recently
from
August 29, 2024 14:08
3d0878d
to
43d91e1
Compare
Introduces a debug panel that provides real-time playback metrics for enhanced monitoring and debugging of the video player. This panel can be added to the player interface only when necessary, allowing developers to keep track of key playback statistics during video streaming. To integrate the debug panel into the player: ```javascript import videojs from 'video.js'; import '@srgssr/pillarbox-debug-panel'; const player = videojs('my-player', { pillarboxDebugPanel: true }); ``` Changes: - Implemented a debug panel displaying metrics such as buffer size, media duration, playback position, bandwidth, bitrate, codecs, framerate, total frames, dropped frames, resolution, and timestamp. - Added a canvas element to the panel for visualizing the evolution of buffer health, bitrate, and bandwidth. - Used VHS API for data retrieval when supported, and native APIs for browsers utilizing native video playback (such as HLS in Safari).
jboix
force-pushed
the
feat/pillarbox-debug-panel
branch
from
August 29, 2024 14:17
43d91e1
to
dbc7e9d
Compare
amtins
approved these changes
Aug 29, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thank you !!!!
🎉 This issue has been resolved in version @srgssr/pillarbox-debug-panel-v1.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Introduces a debug panel that provides real-time playback metrics for enhanced monitoring and debugging of the video player. This panel can be added to the player interface only when necessary, allowing developers to keep track of key playback statistics during video streaming.
To integrate the debug panel into the player:
Changes Made
Checklist