Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mouse zooming #277

Merged
merged 3 commits into from
Sep 14, 2024
Merged

Mouse zooming #277

merged 3 commits into from
Sep 14, 2024

Conversation

rom1dep
Copy link
Contributor

@rom1dep rom1dep commented Sep 11, 2024

No description provided.

by using `key` instead of `keyCode` for keyboard events
This preliminary version only zooms towards the mindmap center, a better
implementation would ensure that the viewport also scrolls towards the cursor
position, but in that regard it's neither better nor worse than the current
keyboard-based zooming implementation.
@SSShooter
Copy link
Owner

Does this PR include the contents of the previous two PRs? If so, should we consolidate everything into this PR?

@rom1dep
Copy link
Contributor Author

rom1dep commented Sep 12, 2024

Does this PR include the contents of the previous two PRs?

Apparently so, the first commit can be taken out, but the 3rd builds on top of the second. If you see an interest in taking them all eventually, we can use this PR and ignore the other two :)

@rom1dep
Copy link
Contributor Author

rom1dep commented Sep 12, 2024

I took the chance to fix the formatting/styling issues over #277 (comment)

src/plugin/keypress.ts Outdated Show resolved Hide resolved
@SSShooter SSShooter merged commit 8bcac77 into SSShooter:master Sep 14, 2024
1 check passed
@SSShooter
Copy link
Owner

Thanks for your PRs 😆

@rom1dep rom1dep deleted the mouse_zooming branch September 14, 2024 18:58
@rom1dep
Copy link
Contributor Author

rom1dep commented Sep 14, 2024

Thanks for your PRs 😆

Thanks for merging them :)

For the record, your project came to my attention because a PR by @eliandoran recently got merged into https://github.com/TriliumNext/Notes/ , and as such, the next version of the TriliumNext Notes taking app/personal wiki will include a mind mapping feature thanks to mind-elixir!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants