-
-
Notifications
You must be signed in to change notification settings - Fork 292
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mouse zooming #277
Mouse zooming #277
Conversation
by using `key` instead of `keyCode` for keyboard events
This preliminary version only zooms towards the mindmap center, a better implementation would ensure that the viewport also scrolls towards the cursor position, but in that regard it's neither better nor worse than the current keyboard-based zooming implementation.
Does this PR include the contents of the previous two PRs? If so, should we consolidate everything into this PR? |
Apparently so, the first commit can be taken out, but the 3rd builds on top of the second. If you see an interest in taking them all eventually, we can use this PR and ignore the other two :) |
486d651
to
4621f0a
Compare
I took the chance to fix the formatting/styling issues over #277 (comment) |
4621f0a
to
2291ac9
Compare
Thanks for your PRs 😆 |
Thanks for merging them :) For the record, your project came to my attention because a PR by @eliandoran recently got merged into https://github.com/TriliumNext/Notes/ , and as such, the next version of the TriliumNext Notes taking app/personal wiki will include a mind mapping feature thanks to mind-elixir! |
No description provided.