Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently it is UB for Rust code to unwind into FFI (except when using
extern "C-unwind"
, but I don't know if that would be safe to use within libdispatch).For async functions, this PR simply aborts the process if the closure panics. For synchronous functions, the panic will be automatically resumed once the dispatch call returns.
While I don't believe this should have a major impact on performance, it's possible, and should probably be benchmarked if possible.