Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

spi: stm32-qspi: Fix wait_cmd timeout in APM mode #16

Closed
wants to merge 1 commit into from
Closed

spi: stm32-qspi: Fix wait_cmd timeout in APM mode #16

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 14 additions & 5 deletions drivers/spi/spi-stm32-qspi.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -425,12 +425,21 @@ static int stm32_qspi_send(struct spi_mem *mem, const struct spi_mem_op *op)
*/
if (err || err_poll_status || qspi->fmode == CCR_FMODE_MM)
goto abort;

if (qspi->fmode != CCR_FMODE_APM) {
/* For CCR_FMODE_APM command and data transfer is triggered in stm32_qspi_wait_poll_status().
* All recieved data (polled data) is then located in fifo and read out in stm32_qspi_tx().
* stm32_qspi_wait_cmd() requires TCF/TEF to be set to finish. Because APM mode doesn't
* provide TCF/TEF this call will timeout
*/
/* wait end of tx in indirect mode */
err = stm32_qspi_wait_cmd(qspi, op);
if (err)
goto abort;
}

/* wait end of tx in indirect mode */
err = stm32_qspi_wait_cmd(qspi, op);
if (err)
goto abort;

/* Clear TCF/TEF flags. Otherwise these flags may trigger wrong code paths in the next op */
writel_relaxed(FCR_CTCF | FCR_CTEF, qspi->io_base + QSPI_FCR);
return 0;

abort:
Expand Down