Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SDSS-1321: Version 1 of mega menu #463

Open
wants to merge 46 commits into
base: 4.x
Choose a base branch
from
Open

SDSS-1321: Version 1 of mega menu #463

wants to merge 46 commits into from

Conversation

jenbreese
Copy link
Contributor

@jenbreese jenbreese commented Jul 9, 2024

READY FOR REVIEW

  • This is ready for another set of eyes.
  • @joegl, Can you create the config for it to turn off an on?
  • @rebeccahongsf Can you review and test the code?

Summary

  • This is a mega menu to work on both Green and Blue headers.
  • You will need to create menu links.
  • The levels shown in the menu are only Level 0 through Level 2. Anything else will only show in the secondary menu.
  • There needs to be a toggle to turn it off and on. Joe is going to create that part.
  • The menu links are displayed in a row rather than column. They'd prefer it to be column.
  • Need to verify that the newsroom menu is uneffected by this change since they share components like the close.

Review By (Date)

  • When does this need to be reviewed by?

Criticality

  • How critical is this PR on a 1-10 scale? See Severity Assessment.
  • E.g., it affects one site, or every site and product?

Review Tasks

Setup tasks and/or behavior to test

  1. Open GitPod for this branch.
  2. Create some pages that you can use for linking in the main menu.
  3. Create levels 0 through 2.
  4. Navigate to a page.
  5. Verify the menu looks like the design for desktop and responsive.
  6. review the code.

Front End Validation

  • Is the markup using the appropriate semantic tags and passes HTML validation?
  • Cross-browser testing has been performed?
  • Automated accessibility scans performed?
  • Manual accessibility tests performed?
  • Design is approved by @ user?

Backend / Functional Validation

Code

  • Are the naming conventions following our standards?
  • Does the code have sufficient inline comments?
  • Is there anything in this code that would be hidden or hard to discover through the UI?
  • Are there any code smells?
  • Are tests provided? eg (unit, behat, or codeception)

Code security

General

  • Is there anything included in this PR that is not related to the problem it is trying to solve?
  • Is the approach to the problem appropriate?

Affected Projects or Products

  • Does this PR impact any particular projects, products, or modules?

Associated Issues and/or People

- SDSS-1321

Resources

@github-actions github-actions bot added the size/s label Jul 9, 2024
@github-actions github-actions bot added the patch label Jul 22, 2024
@jenbreese jenbreese changed the title Mega menu inital explorations Mega menu setup Jul 22, 2024
@github-actions github-actions bot added size/m and removed size/s labels Jul 22, 2024
@jenbreese jenbreese changed the title Mega menu setup SDSS-1321: Version 1 of mega menu Jul 22, 2024
@github-actions github-actions bot removed the patch label Aug 8, 2024
@github-actions github-actions bot added size/l and removed size/m labels Aug 13, 2024
@github-actions github-actions bot added the patch label Sep 6, 2024
@github-actions github-actions bot removed the patch label Sep 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants