Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CSHARP-000 | @jdwjdwjdw | Update Algolia filter sort, responsive fixup #12

Merged
merged 3 commits into from
May 15, 2024

Conversation

jdwjdwjdw
Copy link
Contributor

READY FOR REVIEW

Summary

  • Per related slack conversation, this PR:
    • Removes the sortBy for the Access and Affiliation filter.
    • Responsive fixup so that the image won't get pushed off the page at around 800px (see screenshot before and after). This may be difficult to test since the images aren't being rendered on gitpod. But you should be able to test out the change if you inspect the page at https://csharp2024.sites.stanford.edu/search?search= and make the related adjustment.

Responsive issue before
Screenshot 2024-05-15 at 10 25 27 AM

Responsive issue fixup in the PR
Screenshot 2024-05-15 at 1 43 21 PM

Review By (Date)

  • ASAP

Urgency

  • High

Review Tasks

Setup tasks and/or behavior to test

  1. Check out this branch
  2. Update your site settings to match the Algolia information at https://csharp2024.sites.stanford.edu/admin/config/system/basic-site-settings
  3. Navigate to /search.
  4. Confirm the the Access and Affiliation filter is no longer sorted alphabetically
  5. Confirm that the Hits <article> now goes to flex-direction: row; at 992px instead of 768px
  6. Review code 🎑

Associated Issues and/or People

Copy link
Contributor

@mdyoung3 mdyoung3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mdyoung3 mdyoung3 merged commit 0b5090b into 1.x May 15, 2024
1 check passed
@mdyoung3 mdyoung3 deleted the CSHARP-000--algolia-adjustments branch May 15, 2024 23:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants