Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIXUP - Adding hits per page configuration. #13

Merged
merged 4 commits into from
May 16, 2024
Merged

Conversation

mdyoung3
Copy link
Contributor

@mdyoung3 mdyoung3 commented May 16, 2024

READY FOR REVIEW

  • (Edit the above to reflect status)

Summary

Review By (Date)

  • ASAP

Criticality

  • How critical is this PR on a 1-10 scale? Also see Severity Assessment.
  • E.g., it affects one site, or every site and product?

Urgency

  • How urgent is this? (Normal, High)

Review Tasks

Setup tasks and/or behavior to test

  1. Check out this branch
  2. Head to /search and count results.

Site Configuration Sync

  • Is there a config:export in this PR that changes the config sync directory?

Front End Validation

Backend / Functional Validation

Code

  • Are the naming conventions following our standards?
  • Does the code have sufficient inline comments?
  • Is there anything in this code that would be hidden or hard to discover through the UI?
  • Are there any code smells?
  • Are tests provided? eg (unit, behat, or codeception)

Code security

General

  • Is there anything included in this PR that is not related to the problem it is trying to solve?
  • Is the approach to the problem appropriate?

Affected Projects or Products

  • Does this PR impact any particular projects, products, or modules?

Associated Issues and/or People

  • JIRA ticket(s)
  • Other PRs
  • Any other contextual information that might be helpful (e.g., description of a bug that this PR fixes, new functionality that it adds, etc.)
  • Anyone who should be notified? (@mention them here)

Resources

@github-actions github-actions bot added size/xl and removed size/xs labels May 16, 2024
@mdyoung3 mdyoung3 requested a review from jdwjdwjdw May 16, 2024 22:31
@mdyoung3 mdyoung3 enabled auto-merge (squash) May 16, 2024 23:23
Copy link
Contributor

@jdwjdwjdw jdwjdwjdw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks @mdyoung3!

@mdyoung3 mdyoung3 merged commit 9d15194 into 1.x May 16, 2024
1 check passed
@mdyoung3 mdyoung3 deleted the FIXUP-hits-per-page branch May 16, 2024 23:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants