Skip to content

Commit

Permalink
updates based on feedback
Browse files Browse the repository at this point in the history
  • Loading branch information
jenbreese committed Apr 3, 2024
1 parent 83c0178 commit f172f41
Show file tree
Hide file tree
Showing 6 changed files with 13 additions and 59 deletions.
11 changes: 0 additions & 11 deletions .storybook/stories/config-pages/LocalFooter.stories.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -66,17 +66,6 @@ export const LocalFooterDisplay: Story = {
postalCode: "Postal Code",
sortingCode: "Sorting Code",
},
// Signup form details
suLocalFootFButton: "Sign up footer button",
suLocalFootFIntro: {
processed: "<h2>Signup Form</h2><p>This is an example of a signup form.</p>"
},
suLocalFootFMethod: "Sign up footer method",
suLocalFootFUrl: {
title: "Form Action url",
url: "https://localhost",
internal: false
},
// Footer lockup controls
suLocalFootUseLoc: true,
suLocalFootUseLogo: true,
Expand Down
22 changes: 8 additions & 14 deletions src/components/config-pages/local-footer.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -23,8 +23,6 @@ import InstagramIcon from "@components/elements/icons/InstagramIcon";
import LinkedInIcon from "@components/elements/icons/LinkedInIcon";
import { Maybe, StanfordLocalFooter} from "@lib/gql/__generated__/drupal.d";
import {buildUrl} from "@lib/drupal/utils";
import WebLogin from "@components/elements/web-login";
import Subscribe from "@components/elements/subscribe";

const LocalFooter = ({
suFooterEnabled,
Expand Down Expand Up @@ -75,11 +73,11 @@ const LocalFooter = ({
<div>

{suLocalFootAddress &&
<Address {...suLocalFootAddress}/>
<Address {...suLocalFootAddress} className="text-19 leading-9 rs-mb-3"/>
}

{suLocalFootAction &&
<ul className="list-unstyled text-16 font-semibold rs-mb-3">
<ul className="list-unstyled text-19 font-semibold rs-mb-3">
{suLocalFootAction.map((link, index) => {
if (!link.url) return;
return (
Expand Down Expand Up @@ -114,9 +112,9 @@ const LocalFooter = ({

<div>
{suLocalFootPrimeH &&
<H2 className="text-m1">{suLocalFootPrimeH}</H2>}
<H2>{suLocalFootPrimeH}</H2>}
{suLocalFootPrimary &&
<ul className="list-unstyled text-19 rs-mb-2">
<ul className="list-unstyled text-21 rs-mb-2">
{suLocalFootPrimary.map((link, index) => {
if (!link.url) return;
return (
Expand All @@ -138,7 +136,7 @@ const LocalFooter = ({
<H2 className="text-m0">{suLocalFootSecondH}</H2>}

{suLocalFootSecond &&
<ul className="list-unstyled text-19 rs-mb-2">
<ul className="list-unstyled text-21 rs-mb-2">
{suLocalFootSecond.map((link, index) => {
if (!link.url) return;
return (
Expand All @@ -152,20 +150,16 @@ const LocalFooter = ({
</ul>
}

<Wysiwyg html={suLocalFootTr2Co?.processed} className="text-19"/>
<Wysiwyg html={suLocalFootTr2Co?.processed} className="text-21"/>

</div>

<div>
<div className="su-signup-form">
<Wysiwyg html={suLocalFootFIntro?.processed}/>
<Subscribe/>
</div>
<Wysiwyg html={suLocalFootFIntro?.processed}/>

<Wysiwyg html={suLocalFootTrCo?.processed} className="text-19"/>
<Wysiwyg html={suLocalFootTrCo?.processed} className="text-21"/>
</div>
</div>
<WebLogin/>
</div>
</div>
)
Expand Down
2 changes: 1 addition & 1 deletion src/components/elements/address.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ const Address = ({
}

return (
<address {...props} className="text-16 leading-9 rs-mb-3">
<address {...props}>
{organization && <div className="font-semibold">{organization}</div>}
{(addressLine1) && <div>{addressLine1}</div>}
{(addressLine2) && <div>{addressLine2}</div>}
Expand Down
13 changes: 0 additions & 13 deletions src/components/elements/subscribe.tsx

This file was deleted.

16 changes: 0 additions & 16 deletions src/components/elements/web-login.tsx

This file was deleted.

8 changes: 4 additions & 4 deletions src/styles/typography/local-footer.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -4,16 +4,16 @@ module.exports = function () {
const components = {
'.local-footer': {
'h2': {
fontSize: '.9em',
fontSize: '1em',
},
'h3': {
fontSize: '.8em',
fontSize: '.9em',
},
'h4': {
fontSize: '.8em',
fontSize: '.9em',
},
'p': {
fontSize: '.8em',
fontSize: '.9em',
}
},
};
Expand Down

0 comments on commit f172f41

Please sign in to comment.