Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DS-965: Linting Cache Config & ADR #370

Merged
merged 12 commits into from
Jan 8, 2025
Merged

DS-965: Linting Cache Config & ADR #370

merged 12 commits into from
Jan 8, 2025

Conversation

sherakama
Copy link
Member

@sherakama sherakama commented Nov 25, 2024 •
edited
Loading

READY FOR REVIEW

Summary

  • Catches up on linting config
  • Adds ADRs for decisions
  • Adds fetch caching
  • Hack patch caching setting
  • Adds config settings
  • Adds metadata to our 404 pages

Review By (Date)

  • Whenever you get time when you are back

Criticality

  • Low, maintenance mostly

Review Tasks

  1. Check out this branch or go to the netlify preview
  2. Click around to see that everything still loads and looks good
  3. Review code and read ADRs
  4. Vist a non-existing page and review the document metadata

Associated Issues and/or People

@netlify Netlify
Copy link

netlify bot commented Nov 25, 2024 •
edited
Loading

✅ Deploy Preview for giving-campaign ready!

Name Link
🔨 Latest commit ea6db5b
🔍 Latest deploy log https://app.netlify.com/sites/giving-campaign/deploys/677f0a9ed03401000802b033
😎 Deploy Preview https://deploy-preview-370--giving-campaign.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@sherakama sherakama changed the title NoJira: Linting upgrades. DS-965: Linting Cache Config & ADR Nov 26, 2024
@sherakama sherakama marked this pull request as ready for review November 26, 2024 18:00
@sherakama
Copy link
Member Author

@yvonnetangsu welcome back. When you get some time next week please have a look at this.

@yvonnetangsu
Copy link
Member

@yvonnetangsu welcome back. When you get some time next week please have a look at this.

Thanks for the ping @sherakama ! I'll review early next week. Have a great weekend 😄

@yvonnetangsu
Copy link
Member

@sherakama I owe you reviews. Will do that today 🫡

@yvonnetangsu
Merge branch 'dev' into DS-965/adrs
ea6db5b 
* dev:
  3.3.1
  DS-989 | Use modals for changemaker card content for all breakpoints (#373)
  Support wildcards in redirects. (#372)

# Conflicts:
#	components/ChangemakerCard/ChangemakerCard.tsx
yvonnetangsu
yvonnetangsu reviewed Jan 8, 2025
View reviewed changes
next.config.mjs
// This just reimports the default one but it skips the limit
// See: https://github.com/vercel/next.js/discussions/48324#discussioncomment-10542097
// Remove when upgrading to Next 15+
cacheHandler: path.resolve('node_modules/next/dist/server/lib/incremental-cache/file-system-cache.js'),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👀 Interesting

yvonnetangsu
yvonnetangsu approved these changes Jan 8, 2025
View reviewed changes
Copy link
Member

@yvonnetangsu yvonnetangsu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've checked the deploy preview, within the Storyblok iframe and using localhost. All seems to be working great. Thank you for the linter update as well @sherakama 🎉 😄

@yvonnetangsu yvonnetangsu merged commit e85bfb7 into dev Jan 8, 2025
5 checks passed
@yvonnetangsu yvonnetangsu deleted the DS-965/adrs branch January 8, 2025 23:49
@yvonnetangsu yvonnetangsu mentioned this pull request Jan 9, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yvonnetangsu yvonnetangsu yvonnetangsu approved these changes

Assignees

@yvonnetangsu yvonnetangsu

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sherakama @yvonnetangsu