Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DS-1101 | Add Sa11y #383

Merged
merged 4 commits into from
Jan 27, 2025
Merged

DS-1101 | Add Sa11y #383

merged 4 commits into from
Jan 27, 2025

Conversation

yvonnetangsu
Copy link
Member

@yvonnetangsu yvonnetangsu commented Jan 27, 2025 •
edited
Loading

READY FOR REVIEW

Summary

  • Add Sa11y to Storyblok editing

Review By (Date)

  • Soon

Criticality

  • 5

Review Tasks

Setup tasks and/or behavior to test

  1. Go to Momentum Storyblok
  2. Open up any page in the Momentum directory
  3. Select PR 383 from the visual editor URL
  4. Check that it has the normal Sa11y functionality and there are no errors
    Screenshot 2025-01-27 at 10 37 50 AM

Associated Issues and/or People

@netlify Netlify
Copy link

netlify bot commented Jan 27, 2025 •
edited
Loading

✅ Deploy Preview for giving-campaign ready!

Name Link
🔨 Latest commit 74b5370
🔍 Latest deploy log https://app.netlify.com/sites/giving-campaign/deploys/6797d055820a200008457196
😎 Deploy Preview https://deploy-preview-383--giving-campaign.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@yvonnetangsu yvonnetangsu marked this pull request as ready for review January 27, 2025 18:39
@yvonnetangsu yvonnetangsu merged commit 4818622 into dev Jan 27, 2025
5 checks passed
@yvonnetangsu yvonnetangsu deleted the feature/DS-1101/sa11y branch January 27, 2025 23:58
@yvonnetangsu yvonnetangsu mentioned this pull request Jan 28, 2025
Merged
yvonnetangsu added a commit that referenced this pull request Jan 28, 2025
@yvonnetangsu
Merge branch 'dev' into feature/DS-1021/gallery
d3ad9cc 
* dev:
  3.5.0
  DS-1101 | Add Sa11y (#383)
  DS-1102 | Allow adding custom preview image for Embed Media video light mode (#382)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sherakama sherakama sherakama approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yvonnetangsu @sherakama