HOM-8: Add rel to custom attributes

[sherakama]

NOT READY FOR REVIEW

Summary

• Follow up for HOM-8 | @shc314 @William-Misiaszek | Update referrer url code block #805

Review By (Date)

• When does this need to be reviewed by?

Criticality

• How critical is this PR on a 1-10 scale? Also see Severity Assessment.
• E.g., it affects one site, or every site and product?

Review Tasks

Setup tasks and/or behavior to test

1. Check out this branch
2. Navigate to...
3. Verify...

Front End Validation

• Is the markup using the appropriate semantic tags and passes HTML validation?
• Cross-browser testing has been performed?
• Automated accessibility scans performed?
• Manual accessibility tests performed?
• Design is approved by @ user?

Backend / Functional Validation

Code

• Are the naming conventions following our standards?
• Does the code have sufficient inline comments?
• Is there anything in this code that would be hidden or hard to discover through the UI?
• Are there any code smells?
• Are tests provided? eg (unit, behat, or codeception)

Code security

• Are all forms properly sanitized?
• Any obvious security flaws or new areas for attack?

General

• Is there anything included in this PR that is not related to the problem it is trying to solve?
• Is the approach to the problem appropriate?

Affected Projects or Products

• Does this PR impact any particular projects, products, or modules?

Associated Issues and/or People

• JIRA ticket(s)
• Other PRs
• Any other contextual information that might be helpful (e.g., description of a bug that this PR fixes, new functionality that it adds, etc.)
• Anyone who should be notified? (@mention them here)

Resources

• AMP Tool
• Accessibility Manual Test Script
• HTML Validator
• Browserstack and link to Browserstack Credentials

[sherakama]

The question is, does this conflict or complement the existing solution? How much effort to move all existing solution entries to this method?

[sherakama]

FYI: @yvonnetangsu @shc314 @William-Misiaszek

[shc314]

If the existing documentation tells users to add rel from Other Link Attributes, then perhaps the likelihood that someone will attempt to add it as a Custom Attribute is slim, so it might not actually be an issue.

[yvonnetangsu]

@sherakama @shc314 Just checking in and see what's the status of this PR 👋🏼 😄

[sherakama]

I opened this with every intention of getting to it... someday. Unfortunately, it isn't high on my list but I could be swayed. Is this a priority for you @yvonnetangsu?

[yvonnetangsu]

I opened this with every intention of getting to it... someday. Unfortunately, it isn't high on my list but I could be swayed. Is this a priority for you @yvonnetangsu?

Not a priority for me at all @sherakama - just checking in 🤠