Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mgmtdomains API, better validation and messages #177

Merged
merged 3 commits into from
Jul 12, 2021

Conversation

indy-independence
Copy link
Member

Improve input validating for mgmtdomains using pydantic. Add output after updating a mgmtdomain object. Better error messages for updating/adding mgmtdomains

…fter updating a mgmtdomain object. Better error messages for updating/adding mgmtdomains
@codecov
Copy link

codecov bot commented Jul 9, 2021

Codecov Report

Merging #177 (5d04574) into develop (8df1862) will increase coverage by 0.59%.
The diff coverage is 66.66%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #177      +/-   ##
===========================================
+ Coverage    58.28%   58.87%   +0.59%     
===========================================
  Files           60       60              
  Lines         6002     6040      +38     
===========================================
+ Hits          3498     3556      +58     
+ Misses        2504     2484      -20     
Impacted Files Coverage Δ
src/cnaas_nms/api/mgmtdomain.py 46.15% <56.00%> (+21.34%) ⬆️
src/cnaas_nms/api/generic.py 58.77% <85.18%> (+8.19%) ⬆️
src/cnaas_nms/db/settings_fields.py 94.50% <100.00%> (+0.03%) ⬆️
src/cnaas_nms/db/settings.py 81.69% <0.00%> (+0.26%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8df1862...5d04574. Read the comment docs.

@indy-independence indy-independence merged commit ee5947e into develop Jul 12, 2021
@indy-independence indy-independence deleted the bugfix.mgmtdomain_valid_ip_and_output branch July 12, 2021 07:51
@indy-independence indy-independence added this to the v1.3.0 milestone Jul 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant