This repository has been archived by the owner on Apr 17, 2023. It is now read-only.
Review packaging scripts #299
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
to be used in case the default database configuration is not enough
so that it can be rerun without destroying other configurations
since this is more adequate
So that it prompts the user if he is sure, since this will overwrite local configuration, plus it is not needed if the registry is not in this machine. It will also create a backup copy so that this step can be rolled back.
if registry configuration does not exist, skip configuration
| @@ -0,0 +1,51 @@ | |||
| #!/bin/bash | |||
|
|
|||
| if [[ $(id -u) -ne 0 ]] ; then echo "Please run as root" ; exit 1 ; fi | |||
There was a problem hiding this comment.
Don't write if statements as one-liners
|
LGTM. Just fix the conflicts |
do not have one line if statements
* master: [packaging] set initial database values
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Review scripts so that they can be used for configuration after installing the rpm