set admin user from a rake task and disable first-user is admin

[jordimassaguerpla]

fixes #313

[jordimassaguerpla]

I've set false as default because it is the safest option, but it breaks backward compatibility ... is it ok?

[flavio]

Set first_user_admin to true if you want that the first user that signs up to be an admin.

[flavio]

yeah, I'm a bit sceptical about breaking the compatibility. I wouldn't do it

[mssola]

Same here, default to true. Moreover, the config file is wrong, you should follow the current convention. It should be like this:

# Set to true if you want that the first user that signs up to be an admin. If
# this is false, then you will need to perform the following command to set the admin user:
#  $ rake portus:set_admin
first_user_admin:
  enabled: true

Then, when checking about this in the Ruby code, you write:

APP_CONFIG["first_user_admin"].enabled?

In fact, you can do this check inside the .slim file, there's no need to declare the @first_user_admin variable in the controller in my opinion.

[mssola]

Oh, and by the way, could you update the Changelog ?

[jordimassaguerpla]

does it look good now :)

[mssola]

empty line not needed

[mssola]

LGTM 👏 Just fix my nitpicks and put everything into one commit ;)

[flavio]

+1