Added additional information for teams and namespaces pages #383
Conversation
jloehel
force-pushed
the
Issue201
branch
2 times, most recently
from
60127b6
to
9bd1043
Compare
| old_description: old_description, | ||
| new_description: team_params['description']} | ||
|
|
||
| render js: "window.location = '/teams/#{@team.id}'" |
There was a problem hiding this comment.
Do we really need to force a reload of the entire page, do you think it would be too hard/an overkill to update the different parts of the page?
There was a problem hiding this comment.
I just noticed there's a team_updates.js file, doesn't that make this directive wrong?
There was a problem hiding this comment.
No it's not really needed. You are right. I will move the reload to app/views/teams/update.js.erb and limit the reloading to the specific div-tag.
|
It would be nice to see some screenshots. Also please fix the rubuto issues. |
| old_description: old_description, | ||
| new_description: namespace_params["description"] } | ||
|
|
||
| render js: "window.location = '/namespaces/#{@namespace.id}'" |
There was a problem hiding this comment.
As @flavio pointed out, don't reload the whole page. Moreover, the activity can get crazy since descriptions are just unlimited text. Maybe this can be hidden when showing the view somehow ?
There was a problem hiding this comment.
Shall I limit the length of the description? The view of the activity shows not the value of the description. Only if it has been edited or deleted. Only the csv contains this information. So, I guess I can remove the parameters?
|
Snapshots please :) |
|
Some screenshots:
|
|
There are a couple of things that I don't like: 1st picture
2nd picture
3rd picture
|
|
I totally agree with @flavio. Note that:
These two are unrelated to this change, but maybe it's a good idea to change this while we are at it in this PR :) |
Fixes: SUSE#201 Signed-off-by: Jürgen Löhel <jloehel@suse.com>
|
Additional screenshots:
|
|
That looks definitely better! |
|
LGTM |
|
@flavio do you agree on mergin this ? |
Added additional information for teams and namespaces pages
Fixes: #201
Signed-off-by: Jürgen Löhel jloehel@suse.com