This repository has been archived by the owner on Apr 17, 2023. It is now read-only.
Allowed controlled anonymous access with public namespaces #468
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mssola
force-pushed
the
anonymous-access
branch
2 times, most recently
from
7790d69
to
d886807
Compare
Before this patch, a "public" namespace allowed pulls to any Portus user. However, it did not allow pull access to anonymous users. After this patch, the TokensController won't authenticate every user, but only those that have called the `docker login` command. From now on, it's up to each policy to allow/disallow anonymous users. In particular, the only one that allows access to anonymous users is the Namespace policy, and it only does it for pull requests. Moreover, the UI toggles have now a title that tells the user that by making a namespace public, anyone will be able to pull. Fixes SUSE#279 Signed-off-by: Miquel Sabaté Solà <msabate@suse.com>
mssola
force-pushed
the
anonymous-access
branch
from
d886807
to
27f11b7
Compare
|
LGTM |
mssola
added a commit
that referenced
this pull request
Oct 21, 2015
Allowed controlled anonymous access with public namespaces
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this patch, a "public" namespace allowed pulls to any Portus user.
However, it did not allow pull access to anonymous users.
After this patch, the TokensController won't authenticate every user, but only
those that have called the
docker logincommand. From now on, it's up to eachpolicy to allow/disallow anonymous users. In particular, the only one that
allows access to anonymous users is the Namespace policy, and it only does it
for pull requests.
Fixes #279
Signed-off-by: Miquel Sabaté Solà msabate@suse.com