This repository has been archived by the owner on Apr 17, 2023. It is now read-only.
Better Sub-URI handling & configurable config-local.yml path #851
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM, nice idea the |
|
LGTM, thanks for this 👍 That being said, |
|
This fix should be backported into the |
|
@mssola please cherry-pick this commit into the v2 branch |
Signed-off-by: Alexey Zagarin <zagarin@gmail.com>
leshik
force-pushed
the
better_sub-uri_handling_and_configurable_config_local_path
branch
from
f21864d
to
b73cd26
Compare
|
@mssola Sorry about that, I fixed it. |
|
@leshik thanks 👏 |
mssola
added a commit
to mssola/Portus
that referenced
this pull request
Jan 20, 2017
…fig-local See SUSE#851 Signed-off-by: Miquel Sabaté Solà <msabate@suse.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
Would you mind to add these changes? Both are falling back gracefully and therefore shouldn't break anything.
First change improves Sub-URI compatibility with non-passenger setups: you just set
RAILS_RELATIVE_URL_ROOTenvironment variable to something like/portusand app server starts to serve Portus from subdirectory.Second change adds ability to set custom path to
config-local.ymlfile by settingPORTUS_LOCAL_CONFIG_PATHenvironment variable. This is helpful when setting up on Kubernetes where it's not possible to mount just single file to container, but directory.