Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

zypper-migration: Mark beta products #282

Merged
merged 1 commit into from
Jan 23, 2025
Merged

zypper-migration: Mark beta products #282

merged 1 commit into from
Jan 23, 2025

Conversation

mssola
Copy link
Contributor

@mssola mssola commented Jan 23, 2025

Description

Mark beta products in an uppercase "BETA" string so customers are aware of this fact. This is similar to what we do with products that are already installed, for example.

Fixes bsc#1211609

How to test

Run this inside of a container. On the repository run the following command:

$ docker run --rm --privileged -ti -v $(pwd):/connect registry.suse.com/bci/golang:1.21-openssl

And now from inside the container:

# git config --global --add safe.directory /connect
# cd /connect
# make build
# ./out/suseconnect -r <regcode>
# ./out/zypper-migration

The last step might need to be run twice if the zypper stack is old (which it was in my case). Then, whenever the migration is really computed, it should show something like:

Available migrations:

    1 |SUSE Linux Enterprise Server 15 SP7 x86_64 (BETA)
(and more)

Notice the "BETA" sign, this is the newly introduced string.

Verified

This commit was signed with the committer’s verified signature.
mssola Miquel Sabaté Solà
Mark beta products in an uppercase "BETA" string so customers are aware
of this fact. This is similar to what we do with products that are
already installed, for example.

Fixes bsc#1211609

Signed-off-by: Miquel Sabaté Solà <msabate@suse.com>
@mssola mssola requested a review from felixsch January 23, 2025 10:55
Copy link
Contributor

@felixsch felixsch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 👍

How I reviewed this merge request:

  • Ran zypper-migration and checked the BETA label is present
  • Checked the code for things I would suggest to be changed

As always, if you think I missed something I should test, please let me know!🚀

cheers,

@mssola mssola merged commit 5386c79 into main Jan 23, 2025
2 checks passed
@mssola mssola deleted the zypper-migration-beta branch January 23, 2025 11:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants