Implement simple copy/move ops for Quarks & kubecf #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rebased by Jan Dubois <jan.dubois@suse.com> on 2020-04-28
This is mostly a copy of the copy op, and the implementation is just running a 'copy' followed by a 'remove' of the 'from' location.
To avoid conflicts of upstream ever implements copy/move ops with incompatible semantics. The Q variants are for internal usage of Quarks (and kubecf) for now.
mook-as
reviewed
Apr 29, 2020
f0rmiga
suggested changes
Apr 29, 2020
f0rmiga
approved these changes
Apr 29, 2020
|
Tagged the merge commit with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The copy implementation has been rebased from cppforlife#16.
The move op is just a copy of the copy op, and chains to a trailing remove op.
Both copy & move have been renamed to qcopy and qmove to avoid conflicts if the upstream project ever implements copy/move ops with different semantics.
This PR is in support of cloudfoundry-incubator/quarks-operator#900.