New CI

[stefanotorresi]

Sister PR of ClusterLabs/ha_cluster_exporter#163, most of the code was copy-pasted from there.

[stefanotorresi]

this is now ready for review , but please defer merging until the secrets are properly set in GH.

[arbulu89]

@stefanotorresi I have not checked deeply, but it looks fine.
Some personal thoughts:

• The travis badge in the README should be replaced by a github one (if it exists)

• Now it looks like the changes file is updated from the github release, but we still have the changes file in the source code. How is this working? Maybe we could describe this in the README. Personally, I'm not a big fan of this process (update changes fro GH), but let's see how it goes

• How is the python matrix working? I see that you define the python versions in the tox file and in the github workflow file.

• I see that almost all the osc operations are done in the make file. The container for the CI was created exactly for that, to not duplicate the code in every project we have. If the commands go here it doesn't have sense to use the container anymore. I would use one or the other approach, but the combination of both looks strange.

• Now the CI looks much more complicated than before, essentially because more files are involved. I guess that these files won't be changed at all, so it should be fine

[stefanotorresi]

Thanks for the feedback, Xabi!

• The travis badge in the README should be replaced by a github one (if it exists)

Done! For the time being, I didn't replace the codeclimate one, though. I will explore this in the future for all the exporters.

• Now it looks like the changes file is updated from the github release, but we still have the changes file in the source code. How is this working? Maybe we could describe this in the README. Personally, I'm not a big fan of this process (update changes fro GH), but let's see how it goes

This was actually a mistake on my part: I have removed the changes file now, because it is managed automatically. This only applies to the exporter, mind you.

I have left the README mostly un-touched here, but I have another PR coming up that overhauls it entirely, because some instructions are outdated.

• How is the python matrix working? I see that you define the python versions in the tox file and in the github workflow file.

The two are not strictly related. We run the test job in both python 3.6 and 3.8. We use the tox py env to automatically get the currently installed python version. The other tox envs are only useful to run tests locally in systems with multiple python versions installed.

• I see that almost all the osc operations are done in the make file. The container for the CI was created exactly for that, to not duplicate the code in every project we have. If the commands go here it doesn't have sense to use the container anymore. I would use one or the other approach, but the combination of both looks strange.

The container is still needed to provide an environment with osc installed and configured. I haven't yet had the chance to move what is being done in the make targets into the scripts within the container, but this would certainly be a very welcomed improvement! For the time being, copy-pasting was the simplest approach.
The way forward would probably be to create a custom reusable GitHub action (which at the end of the day is just a container and a bash script with a specific interface).

• Now the CI looks much more complicated than before, essentially because more files are involved. I guess that these files won't be changed at all, so it should be fine

Heh, that's the trade-off for using the same repo for two packages, but I think it's worth it. Making related changes to both the exporter and the dashboards is a much smoother process now, e.g. see ClusterLabs/ha_cluster_exporter#167.

[arbulu89]

Thanks for clarifying everything @stefanotorresi
I think we are ready to go!