Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add stub request #1243

Merged
merged 2 commits into from
Nov 5, 2024
Merged

add stub request #1243

merged 2 commits into from
Nov 5, 2024

Conversation

jesusbv
Copy link
Collaborator

@jesusbv jesusbv commented Nov 4, 2024

Description

PR to fix the 3 errors found on the CI of the public cloud engines

How to test

CI should not fail

Change Type

Please select the correct option.

  • Bug Fix (a non-breaking change which fixes an issue)
  • New Feature (a non-breaking change which adds new functionality)
  • Documentation Update (a change which only updates documentation)

Checklist

Please check off each item if the requirement is met.

  • I have reviewed my own code and believe that it's ready for an external review.
  • I have provided comments for any hard-to-understand code.
  • I have documented the MANUAL.md file with any changes to the user experience.
  • If my changes are non-trivial, I have added a changelog entry to notify users at package/obs/rmt-server.changes.

Review

Please check out our review guidelines
and get in touch with the author to get a shared understanding of the change.

@jesusbv jesusbv self-assigned this Nov 4, 2024
@jesusbv jesusbv marked this pull request as draft November 4, 2024 16:37
@jesusbv jesusbv force-pushed the fix-tests branch 2 times, most recently from 913d2ab to e2dd8e6 Compare November 5, 2024 14:17
Error gets built automagically by rspec,
no need to { error: <string> }.to_json
Expect was too granular and specific
@jesusbv jesusbv marked this pull request as ready for review November 5, 2024 14:58
Copy link
Contributor

@ngetahun ngetahun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ngetahun ngetahun merged commit 1500238 into master Nov 5, 2024
3 checks passed
@ngetahun ngetahun deleted the fix-tests branch November 5, 2024 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants