Skip to content

Commit

Permalink
ceph: clean up verbose logging
Browse files Browse the repository at this point in the history
The log messages for orchestrations being skipped due to nodes still
being schedulable or unschedulable is filling the logs and not necessary.
The log message for reconciling is now debug, and also fixed another
formatting log message.

Signed-off-by: travisn <tnielsen@redhat.com>
  • Loading branch information
travisn committed Aug 30, 2019
1 parent 09c4858 commit a9deac7
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 4 deletions.
6 changes: 3 additions & 3 deletions pkg/operator/ceph/cluster/controller.go
Original file line number Diff line number Diff line change
Expand Up @@ -486,11 +486,11 @@ func (c *ClusterController) onK8sNodeUpdate(oldObj, newObj interface{}) {

// Checking for NoSchedule added to storage node
if oldNodeSchedulable == false && newNodeSchedulable == false {
logger.Debugf("Skipping cluster update. Updated node %s was and is still unschedulable", newNode.Labels[v1.LabelHostname])
// Skipping cluster update. Updated node was and is still unschedulable
return
}
if oldNodeSchedulable == true && newNodeSchedulable == true {
logger.Debugf("Skipping cluster update. Updated node %s was and it is still schedulable", oldNode.Labels[v1.LabelHostname])
// Skipping cluster update. Updated node was and is still schedulable
return
}

Expand Down Expand Up @@ -711,7 +711,7 @@ func (c *ClusterController) onDeviceCMUpdate(oldObj, newObj interface{}) {

for _, cluster := range c.clusterMap {
if cluster.Info == nil {
logger.Info("Cluster %s is not ready. Skipping orchestration on device change", cluster.Namespace)
logger.Infof("Cluster %s is not ready. Skipping orchestration on device change", cluster.Namespace)
continue
}
logger.Infof("Running orchestration for namespace %s after device change", cluster.Namespace)
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -92,7 +92,7 @@ func (r *ReconcileClusterDisruption) reconcile(request reconcile.Request) (recon
logger.Debugf("discovered NamespacedName: %s", request.NamespacedName)
}
r.namelessRetries = 0
logger.Infof("reconciling %s", request.NamespacedName)
logger.Debugf("reconciling %s", request.NamespacedName)

// get the ceph cluster
cephCluster := &cephv1.CephCluster{}
Expand Down

0 comments on commit a9deac7

Please sign in to comment.