-
Notifications
You must be signed in to change notification settings - Fork 57
Conversation
avoid checksum errors that could be present and require minimal golang version see (golang/go#29278)
@MalloZup Could you check which go version is used to build caaspctl in Devel:CaaSP:4.0 and SUSE:SLE-15-SP1:U:P:CASP40? You can use the "osc buildinfo" command with the caaspctl package checkout. If we use go1.12, I am fine with this change. |
|
I think we have 2 solution. This would be the cleanest one but I'm not sure how it can impact the pkg (obs, ci and openSUSE leap pkg). 2nd solution could be to remove go sum and put it to gitignore. It might be the less impact solution |
Sorry for jumping in here but @MalloZup requested my review. The change LGTM, but I would recommend to check your imports. For example the commit I think it would be cool to have a module validation as Makefile target, like this: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just checked. So we have go1.12 because we use that for k8s. However, caaspctl is pulling go1.11, so we could use go1.12 but you need to adapt the spec file to make sure we pull go1.12
You most probably will have to change this https://github.com/SUSE/caaspctl/blob/master/ci/packaging/suse/caaspctl_spec_template#L30 |
I think this ISSUE require some thinking And discussion. For the moment i will try to don't solve the problem. Creating an issue we can think later and closing this pr |
avoid checksum errors that could be present and require minimal golang
version for fixing it. see (golang/go#29278)
IF we don't have this we will have some issues with the
go.sum
checksuminfo:
On the OBS side, i dunno if this can cause issue I don' think