Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge upstream #376

Merged
merged 54 commits into from
May 13, 2020
Merged

Merge upstream #376

merged 54 commits into from
May 13, 2020

Conversation

richard-cox
Copy link
Member

No description provided.

richard-cox and others added 30 commits April 9, 2020 09:27
- When apps collection is fetched and exceeds maxed allowed certain monitor observables were still firing with the partial collection of apps
- This led to app based stats (like count and memory) to be shown on the space cards & summary
- This was caused by a correction to the pagination monitor to use 'local' monitor observables instead of non-local
- The now correct observable to use did not have a filter for maxed results, so emited the bad data
Fix uaa docs. Make UAA endpoint config simpler
…stats

Ensure we filter out maxed results for local lists
…nt. (cloudfoundry#4252)

* Add nodeSelector template and tests

Add nodeSelector template to the helm deployment:
- deployment.yaml
- database.yaml
- config-init.yaml

Add tests to validate nodeSelector template to
- deployment_test.yaml

Create tests to validate nodeSelector template to
- database_test.yaml
- config_init_test.yaml

* Add c&p fix and another nodeSelector test

Add fix for c&p bug to
- database.yaml
- deployment.yaml

Add test to validate nodeSelector template to
- config_init_test.yaml

Add test config to
- database-test.yaml
- deployment-test.yaml

* Remove test

Remove test to validate nodeSelector template to
    - config_init_test.yaml
Helm Chart: Fix Helm 3 compatibility with Release.Time
* Helm Chart: Fix Helm 3 compatibility with Release.Time

* Add helm 3 lint
nwmac and others added 24 commits May 7, 2020 10:28
* Add nodeSelector template and tests

Add nodeSelector template to the helm deployment:
- deployment.yaml
- database.yaml
- config-init.yaml

Add tests to validate nodeSelector template to
- deployment_test.yaml

Create tests to validate nodeSelector template to
- database_test.yaml
- config_init_test.yaml

* Add c&p fix and another nodeSelector test

Add fix for c&p bug to
- database.yaml
- deployment.yaml

Add test to validate nodeSelector template to
- config_init_test.yaml

Add test config to
- database-test.yaml
- deployment-test.yaml

* Remove test

Remove test to validate nodeSelector template to
    - config_init_test.yaml

* More gates on node selector. Added to values.yaml and README

Co-authored-by: Johannes Jungkunst <macevil@gmail.com>
* Speed up form fill

* Manage users fix?

* Wait slightly longer

* Improve error output in tests

* Fix invite users error msg check

* Fix manage users e2e

* Need checked in form to check box correctly
* Fix row highlight (see app github tab commit table)
- wasn't showing after list in list changes
- fixes cloudfoundry#4243

* Improve metrics view

* Fix code climate issues

* Fix 2 more code climate issues

* Fix merge issue

* Fix dark mode box shadow
- dark mode styling overode disabling of box shadow

* Fix multiple metrics requests due to recreated list cards

* Fix most additional /stratos requests on load of endpoints page with metrics

* Fix unit tests

* Fix EndpointCardComponent test

* Fix root list colour in metrics summary page dark mode

* Fix first row alignment in users table

* Fix invite user e2e test (see cloudfoundry#4272)

* Disable random route override setting when deploying apps in e2e tests
- pushes route over max 63 chars

Co-authored-by: Neil MacDougall <neil.macdougall@suse.com>
…4258)

* Improve metrics view

* Fix code climate issues

* Fix 2 more code climate issues

* Fix merge issue

* Fix multiple metrics requests due to recreated list cards

* Fix most additional /stratos requests on load of endpoints page with metrics

* Fix unit tests

* Fix EndpointCardComponent test

Co-authored-by: Richard Cox <richard.cox@suse.com>
* Fix row highlight (see app github tab commit table)
- wasn't showing after list in list changes
- fixes cloudfoundry#4243

* Fix dark mode box shadow
- dark mode styling overode disabling of box shadow

Co-authored-by: Neil MacDougall <neil.macdougall@suse.com>
* E2E Cleanup script: clean other users and reduce time to 1 hour

* Remove superfluous blank lines

* Revert back to 2 hours
* Speed up form fill

* Fix page set setting

* Remove whitespace
- remove calls to fetchUserProfile
- ensure entity service is used instead of monitor (will fetch profile)
- update FetchUserProfileAction action to a EntityRequestAction
- there's no response to update profile, so ensure we fetch profile again afterwards
- also fixed issue where metrics endpoint reporting a k8s endpoint would cause a console.error
…ment

Fix icon alignment on service marketplace view
…s-fix

Only show metrics details on endpoint card/list when connected
…expiry

CF Push: A better fix for the token expiry issue
@richard-cox richard-cox added the ready for review Ready for review label May 13, 2020
@richard-cox richard-cox requested a review from nwmac May 13, 2020 13:47
@richard-cox richard-cox self-assigned this May 13, 2020
Copy link
Member

@nwmac nwmac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nwmac nwmac merged commit 76049dc into master May 13, 2020
@nwmac nwmac deleted the merge-upstream branch May 13, 2020 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready for review Ready for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants