Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

어드민 서술형문제 수정페이지에 "X"가 모범답안으로 추가되는 버그 수정 #116

Merged
merged 1 commit into from
Jan 21, 2024

Conversation

Kim-Hyunjo
Copy link
Member

MUI에서 aria-hidden으로 숨겨놓은 input이 있었음

Issue Number

close: #444

작업 내역

구현 내용 및 작업 했던 내역

  • 어드민 서술형문제 수정페이지에 "X"가 모범답안으로 추가되는 버그 수정 (MUI에서 aria-hidden으로 숨겨놓은 input이 있었음)

작업 유형

  • 신규 기능 추가
  • 버그 수정
  • 리펙토링
  • 문서 업데이트

PR 특이 사항

PR을 볼 때 주의깊게 봐야하거나 말하고 싶은 점

  • 모범답안 삭제 & 문제 활성화 안됨 이슈로 버그가 완벽히 수정되었는지 확인이 어려웠음 (그래도 된거같음)

MUI에서 aria-hidden으로 숨겨놓은 input이 있었음
Comment on lines +90 to +92
)
.filter((e) => !e.ariaHidden)
.map((e) => e.value) || [],
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

) 와 . 이 떨어져있는걸 붙여보는건 어떤가요.

Copy link
Member Author

@Kim-Hyunjo Kim-Hyunjo Jan 21, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

하지만 저의 소중한 prettier가 저게 더 맘에 든다는데요,,

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:(

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Kim-Hyunjo 고고

@Kim-Hyunjo Kim-Hyunjo merged commit 839e7d6 into dev Jan 21, 2024
1 check passed
@Kim-Hyunjo Kim-Hyunjo deleted the feat/444 branch January 21, 2024 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants