Pick "[fix](planner) failed to create view when use window function (a…

…pache#17815)" (apache#1592)

fix failed to create view when use window function because the view string contains slot id and which cannot be parsed.

Co-authored-by: mch_ucchi <41606806+sohardforaname@users.noreply.github.com>

fe/fe-core/src/main/java/org/apache/doris/analysis/SelectStmt.java

@@ -42,6 +42,7 @@
 import org.apache.doris.common.TreeNode;
 import org.apache.doris.common.UserException;
 import org.apache.doris.common.util.SqlUtils;
+import org.apache.doris.common.util.ToSqlContext;
 import org.apache.doris.mysql.privilege.PrivPredicate;
 import org.apache.doris.qe.ConnectContext;
 import org.apache.doris.rewrite.ExprRewriter;
@@ -1950,7 +1951,9 @@ private boolean checkSortNodeEliminable(Expr expr, List<SlotRef> sortSlotRefs) {
     @Override
     public String toSql() {
         if (sqlString != null) {
-            return sqlString;
+            if (ToSqlContext.get() == null || ToSqlContext.get().isNeedSlotRefId()) {
+                return sqlString;
+            }
         }
         StringBuilder strBuilder = new StringBuilder();
         if (withClause != null) {

regression-test/suites/query_p0/sql_functions/window_functions/test_window_fn.groovy

@@ -356,6 +356,14 @@ suite("test_window_fn") {
         from example_window_tb;
     """
 
+    sql """
+        create view v as select row_number() over(partition by u_city order by u_salary) as wf from example_window_tb    
+    """
+
+    sql """
+        drop view v
+    """
+
     sql "DROP TABLE IF EXISTS example_window_tb;"
 }