-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
M3-117 개인전 픽셀 가져오는 API 구현 완료 #4
Conversation
@RestController | ||
@RequiredArgsConstructor | ||
@RequestMapping("/api/pixels") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
개인 픽셀이랑 경쟁 픽셀이랑 구분하기 위해 엔드포인트에 구분자가 필요할 것 같네요..
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
적용 완료했습니다!
private final PixelRepository pixelRepository; | ||
|
||
public List<IndividualPixelResponse> getNearIndividualPixels(int currentX, int currentY, int xRange, int yRange) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
개인 픽셀과 경쟁 픽셀을 조회 하는 구분이 필요할 것 같아요
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
생각하지 못했던 구분이였네요.. 추후 동적 쿼리나 컨트롤러 단에 구분자 추가 등으로 적용하겠습니다.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
스프링으로 쿼리를 잘 짜신것 같습니다
작업 내용*
고민한 내용*
리뷰 요구사항