Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

M3-212 즐겨찾기 등록, 삭제, 수정 #61

Merged
merged 9 commits into from
Aug 9, 2024

Conversation

tkdals802
Copy link
Contributor

작업 내용*

  • 즐겨찾기 장소를 등록, 수정, 삭제한다

고민한 내용*

  • HOME, COMPANY, ELSE로 최대 3군데까지 등록이 가능하다
  • 즐겨찾기를 수정하면 id로 정렬해서 각 enum에서 가장 id가 큰 녀석들만 가져온다
  • 즐겨찾기를 삭제하게 되면 한 enum의 모든 기록을 삭제해야 하므로 (userid, enum)으로 찾은 모든 값을 삭제한다

리뷰 요구사항

  • 함수, 변수, 로직

Copy link

github-actions bot commented Aug 8, 2024

Qodana for JVM

It seems all right 👌

No new problems were found according to the checks applied

💡 Qodana analysis was run in the pull request mode: only the changed files were checked
☁️ View the detailed Qodana report

Contact Qodana team

Contact us at qodana-support@jetbrains.com

Copy link

github-actions bot commented Aug 8, 2024

📝 테스트 커버리지 리포트

Overall Project 70.96% -2.56% 🍏
Files changed 48.74%

File Coverage
MyPlaceService.java 54.74% -45.26%
MyPlaceController.java 25% -75%

@tkdals802 tkdals802 self-assigned this Aug 8, 2024
@qjvk2880 qjvk2880 merged commit 78d98f3 into develop Aug 9, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants