Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

M3-293 푸시 알림 권한 동의 api 구현 #65

Merged
merged 14 commits into from
Aug 18, 2024

Conversation

koomin1227
Copy link
Member

작업 내용*

  • 회원가입시 permission 데이터를 생성한다.
  • 권한을 처리하는 api 구현
  • 권한 정보를 반환하는 api 구현

고민한 내용*

푸시 알림을 보내기전에 권한에 따라 보내야 하기 때문에 권한을 관리하는 기능을 우선적으로 개발했다.

리뷰 요구사항

  • 리뷰할 때 중점적으로 봐줬으면 하는 내용들

스크린샷

Copy link

github-actions bot commented Aug 14, 2024

📝 테스트 커버리지 리포트

Overall Project 71.85% -1.67% 🍏
Files changed 73.94%

File Coverage
AuthService.java 100% 🍏
FcmService.java 100% 🍏
PermissionService.java 76.42% -23.58%
PermissionController.java 35.71% -64.29%

Copy link

github-actions bot commented Aug 14, 2024

Qodana for JVM

It seems all right 👌

No new problems were found according to the checks applied

💡 Qodana analysis was run in the pull request mode: only the changed files were checked
☁️ View the detailed Qodana report

Contact Qodana team

Contact us at qodana-support@jetbrains.com

@koomin1227 koomin1227 self-assigned this Aug 17, 2024
@qjvk2880 qjvk2880 merged commit c91bb5d into develop Aug 18, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants