M3-140 픽셀 개인전 정보를 가져오는 API 다시 만들기 #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
📝 테스트 커버리지 리포트
|
Qodana for JVMIt seems all right 👌 No new problems were found according to the checks applied 💡 Qodana analysis was run in the pull request mode: only the changed files were checked Contact Qodana teamContact us at qodana-support@jetbrains.com
|
📝 테스트 커버리지 리포트
|
📝 테스트 커버리지 리포트
|
📝 테스트 커버리지 리포트
|
📝 테스트 커버리지 리포트
|
koomin1227
approved these changes
Jun 26, 2024
| public List<IndividualPixelResponse> getNearIndividualPixelsByCoordinate(double currentLatitude, | ||
| double currentLongitude, int radius) { | ||
| Point point = geometryFactory.createPoint(new Coordinate(currentLongitude, currentLatitude)); | ||
| point.setSRID(4326); |
Comment on lines
+13
to
+48
| @Query(value = """ | ||
| WITH PixelsInRange AS ( | ||
| SELECT | ||
| p.pixel_id, | ||
| p.coordinate, | ||
| p.x, | ||
| p.y | ||
| FROM | ||
| pixel p | ||
| WHERE | ||
| ST_CONTAINS((ST_Buffer(:center, :radius)), p.coordinate) | ||
| ), | ||
| RecentVisits AS ( | ||
| SELECT | ||
| pu.pixel_id, | ||
| pu.user_id, | ||
| pu.created_at, | ||
| ROW_NUMBER() OVER (PARTITION BY pu.pixel_id ORDER BY pu.created_at DESC) AS rn | ||
| FROM | ||
| pixel_user pu | ||
| JOIN | ||
| PixelsInRange pir ON pu.pixel_id = pir.pixel_id | ||
| ) | ||
| SELECT | ||
| pir.pixel_id AS pixelId, | ||
| pir.coordinate, | ||
| rv.user_id AS userId, | ||
| pir.x, | ||
| pir.y | ||
| FROM | ||
| PixelsInRange pir | ||
| JOIN | ||
| RecentVisits rv ON pir.pixel_id = rv.pixel_id | ||
| WHERE | ||
| rv.rn = 1 | ||
| """, nativeQuery = true) |
There was a problem hiding this comment.
쿼리 잘 짜셨네요. 저번에 말한 쿼리보다 길긴 하지만 성능이 좋아진 것 같아 좋은 것 같습니다. gis 인덱스가 빠르네요~
tkdals802
approved these changes
Jun 26, 2024
| return Response.createSuccess(pixelService.getNearIndividualPixels(currentX, currentY, xRange, yRange)); | ||
| @RequestParam(name = "current-latitude") double currentLatitude, | ||
| @RequestParam(name = "current-longitude") double currentLongitude, | ||
| @RequestParam(name = "radius") int radius) { |
There was a problem hiding this comment.
radius이 무엇을 중심으로 하는지 나타내는 것은 어떨까요?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
작업 내용*
고민한 내용*
스크린샷