Improve language detection #732
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trungkienbkhn
force-pushed
the
improve-language-detection
branch
from
301eeaf to
01f45df
Compare
emanueleielo
approved these changes
Mar 8, 2024
ddorian
reviewed
Mar 11, 2024
trungkienbkhn
force-pushed
the
improve-language-detection
branch
from
01f45df to
305c63f
Compare
Purfview
added a commit
to Purfview/faster-whisper
that referenced
this pull request
Mar 31, 2024
Regression since SYSTRAN#732 PR
nguyendc-systran
pushed a commit
that referenced
this pull request
Apr 2, 2024
* Bugfix: code breaks if audio is empty Regression since #732 PR
MahmoudAshraf97
added a commit
that referenced
this pull request
Nov 16, 2024
* Supported new options for batched transcriptions: * `language_detection_threshold` * `language_detection_segments` * Updated `WhisperModel.detect_language` function to include the improved language detection from #732 and added docstrings, it's now used inside `transcribe` function. * Removed the following functions as they are no longer needed: * `WhisperModel.detect_language_multi_segment` and its test * `BatchedInferencePipeline.get_language_and_tokenizer` * Added tests for empty audios
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Same with openai/whisper#676