make faster_whisper.assets as a valid python package to distribute (#772) #774
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…YSTRAN#772) faster_whisper use `find_packages` in setup.py to scan directories and distribute valid python packages. According to https://setuptools.pypa.io/en/latest/userguide/package_discovery.html, the `find_packages` function will ignore `faster_whisper/assets` which is not a valid python package because it does not contain `__init__.py`. However, when I build the package, setuptools raise a waring as SYSTRAN#772, and I do not know why. So I add `__init__.py` under the `faster_whisper.assets` directory, making setuptools regard `faster_whisper.assets` is a part of distribution.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
faster_whisper use
find_packagesin setup.py to scan directories and distribute valid python packages. According tohttps://setuptools.pypa.io/en/latest/userguide/package_discovery.html, the
find_packagesfunction will ignorefaster_whisper/assetswhich is not a valid python package because it does not contain__init__.py.However, when I build the package, setuptools raise a waring as #772, and I do not know why. So I add
__init__.pyunder thefaster_whisper.assetsdirectory, making setuptools regardfaster_whisper.assetsis a part of distribution.